Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sliding Sync: Short-circuit have_finished_sliding_sync_background_jobs when checking bump_stamp #17723

Merged

Conversation

MadLittleMods
Copy link
Contributor

@MadLittleMods MadLittleMods commented Sep 17, 2024

Short-circuit have_finished_sliding_sync_background_jobs when checking bump_stamp. We only need to check it if returned bump stamp is None, which is rare.

Pulling this change out from one of @erikjohnston's branches (develop...erikj/ss_perf)

Pull Request Checklist

  • Pull request is based on the develop branch
  • Pull request includes a changelog file. The entry should:
    • Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
    • Use markdown where necessary, mostly for code blocks.
    • End with either a period (.) or an exclamation mark (!).
    • Start with a capital letter.
    • Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
  • Code style is correct
    (run the linters)

We only need to check this if returned bump stamp is `None`, which is
rare.
@MadLittleMods MadLittleMods marked this pull request as ready for review September 17, 2024 21:33
@MadLittleMods MadLittleMods requested a review from a team as a code owner September 17, 2024 21:33
Copy link
Member

@devonh devonh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice little improvement

@MadLittleMods MadLittleMods merged commit 8881ad6 into develop Sep 17, 2024
39 checks passed
@MadLittleMods MadLittleMods deleted the madlittlemods/ss-check-background-job-status-less branch September 17, 2024 22:37
@MadLittleMods
Copy link
Contributor Author

Thanks for the review @devonh 🐬

@MadLittleMods MadLittleMods changed the title Sliding Sync: Short-circuit have_finished_sliding_sync_background_jobs Sliding Sync: Short-circuit have_finished_sliding_sync_background_jobs when checking bump_stamp Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants