Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix develop build #27901

Merged
merged 1 commit into from
Aug 5, 2024
Merged

Fix develop build #27901

merged 1 commit into from
Aug 5, 2024

Conversation

florianduros
Copy link
Member

@florianduros florianduros commented Aug 5, 2024 •
edited
Loading

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • Sign-off given on the changes (see CONTRIBUTING.md).

Use console.warn instead of an undefined compilation object.

Fix develop build https://github.com/element-hq/element-web/actions/runs/10249545922/job/28353165571
According to https://www.npmjs.com/package/@sentry/webpack-plugin#errorhandler only the error object is a parameter of the callback

@florianduros florianduros added the T-Task Tasks for the team like planning label Aug 5, 2024
@florianduros florianduros marked this pull request as ready for review August 5, 2024 17:22
@florianduros florianduros requested a review from a team as a code owner August 5, 2024 17:22
@florianduros florianduros added this pull request to the merge queue Aug 5, 2024
Merged via the queue into develop with commit 7073fb2 Aug 5, 2024
45 of 46 checks passed
@florianduros florianduros deleted the florianduros/ci/fix-build branch August 5, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbkr dbkr dbkr approved these changes

@t3chguy t3chguy Awaiting requested review from t3chguy t3chguy is a code owner automatically assigned from element-hq/element-web-reviewers

@robintown robintown Awaiting requested review from robintown robintown is a code owner automatically assigned from element-hq/element-web-reviewers

Assignees
No one assigned
Labels
T-Task Tasks for the team like planning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@florianduros @dbkr