Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide screenshare button in video rooms on Desktop #22810

Merged
merged 2 commits into from
Jul 12, 2022
Merged

Hide screenshare button in video rooms on Desktop #22810

merged 2 commits into from
Jul 12, 2022

Conversation

robintown
Copy link
Member

@robintown robintown commented Jul 11, 2022 •
edited by github-actions bot
Loading

As a stopgap solution for element-hq/element-desktop#683, we can hide the screensharing button in video rooms if the platform doesn't support it.

Depends on matrix-org/matrix-react-sdk#9045

Notes: none
(notes handled in the react-sdk PR)

This change has no change notes, so will not be included in the changelog.

@robintown robintown requested a review from a team as a code owner July 11, 2022 19:12
@robintown robintown mentioned this pull request Jul 11, 2022
Merged
SimonBrandner
SimonBrandner approved these changes Jul 12, 2022
View reviewed changes
Copy link
Contributor

@SimonBrandner SimonBrandner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Argh, I didn't realize the order of the buttons mattered - feel free to revert if you found the previous solution clearer

@robintown robintown merged commit 796aeff into element-hq:develop Jul 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SimonBrandner SimonBrandner SimonBrandner approved these changes

@andybalaam andybalaam Awaiting requested review from andybalaam andybalaam is a code owner automatically assigned from element-hq/element-web-reviewers

@germain-gg germain-gg Awaiting requested review from germain-gg germain-gg is a code owner automatically assigned from element-hq/element-web-reviewers

@dbkr dbkr Awaiting requested review from dbkr dbkr is a code owner automatically assigned from element-hq/element-web-reviewers

Assignees
No one assigned
Labels
T-Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robintown @SimonBrandner