Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show all reactions in modal #9723

Open
nadonomy opened this issue May 14, 2019 · 4 comments
Open

Show all reactions in modal #9723

nadonomy opened this issue May 14, 2019 · 4 comments
Assignees
@chillmastonmuutos
Labels
A-Aggregations A-Reactions O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist T-Enhancement X-Needs-Design

Comments

@nadonomy
Copy link
Contributor

nadonomy commented May 14, 2019 •
edited
Loading

(Internal) Zeplin link: https://zpl.io/a3e7okQ

Screenshot 2019-05-17 at 15 47 03

  • Accessed from a button labelled 'Reactions' in the more/context menu, which should be absent if a message has no reactions
  • Shows timestamp on hover
  • Allows moderators to remove reactions, using a vertical [...] & context menu to prevent accidental clicks like the room list

Before kicking off dev, we should discuss:

  • Sort orders of reactions (by count?) and names (alphabetically?)
  • Confirm we're happy with the design— left panel vertically scrolls if there's too many reactions
  • Discuss if we should expose mxid's
  • Discuss utility of viewing member profiles from this modal—would need to dismiss the modal to reveal in right panel, which won't feel great
@nadonomy nadonomy mentioned this issue May 15, 2019
Closed
@jryans jryans mentioned this issue May 15, 2019
Closed
@lampholder lampholder added phase:4 and removed phase:3 labels Jul 2, 2019
@babolivier
Copy link
Contributor

This would be really helpful. A few orgs using Matrix seem to use the "react here to get an invite/register interest/etc" and it's a bit sad that the only way for them to see the full list of reactions is by looking at a different app (since the Element mobile apps support this use case).

@SimonBrandner SimonBrandner mentioned this issue Sep 20, 2021
Closed
@SimonBrandner SimonBrandner mentioned this issue Feb 10, 2022
Closed
@SimonBrandner SimonBrandner added the O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience label Feb 10, 2022
@chillmastonmuutos
Copy link

I'm working on this.

@chillmastonmuutos chillmastonmuutos mentioned this issue Mar 14, 2022
Closed
@turt2live turt2live added the S-Minor Impairs non-critical functionality or suitable workarounds exist label May 7, 2022
@turt2live
Copy link
Member

it's a bit embarrassing that mobile has this and we don't, still. PR open at matrix-org/matrix-react-sdk#8051 needs design review.

su-ex added a commit to SchildiChat/element-web that referenced this issue Jan 15, 2023
@su-ex
Merge tag 'v1.11.17' into sc
eac9806 
* Add inline code formatting to rich text editor ([\element-hq#9720](matrix-org/matrix-react-sdk#9720)).
* Add emoji handling for plain text mode of the new rich text editor ([\element-hq#9727](matrix-org/matrix-react-sdk#9727)).
* Overlay virtual room call events into main timeline ([\element-hq#9626](matrix-org/matrix-react-sdk#9626)). Fixes element-hq#22929.
* Adds a new section under "Room Settings" > "Roles & Permissions" which adds the possibility to multiselect users from this room and grant them more permissions. ([\element-hq#9596](matrix-org/matrix-react-sdk#9596)). Contributed by @GoodGuyMarco.
* Add emoji handling for rich text mode ([\element-hq#9661](matrix-org/matrix-react-sdk#9661)).
* Add setting to hide bold notifications ([\element-hq#9705](matrix-org/matrix-react-sdk#9705)).
* Further password reset flow enhancements ([\element-hq#9662](matrix-org/matrix-react-sdk#9662)).
* Snooze the bulk unverified sessions reminder on dismiss ([\element-hq#9706](matrix-org/matrix-react-sdk#9706)).
* Honor advanced audio processing settings when recording voice messages ([\element-hq#9610](matrix-org/matrix-react-sdk#9610)). Contributed by @MrAnno.
* Improve the visual balance of bubble layout ([\element-hq#9704](matrix-org/matrix-react-sdk#9704)).
* Add config setting to disable bulk unverified sessions nag ([\element-hq#9657](matrix-org/matrix-react-sdk#9657)).
* Only display bulk unverified sessions nag when current sessions is verified ([\element-hq#9656](matrix-org/matrix-react-sdk#9656)).
* Separate labs and betas more clearly ([\element-hq#8969](matrix-org/matrix-react-sdk#8969)). Fixes element-hq#22706.
* Show user an error if we fail to create a DM for verification. ([\element-hq#9624](matrix-org/matrix-react-sdk#9624)).
* Prevent unnecessary m.direct updates ([\element-hq#9805](matrix-org/matrix-react-sdk#9805)). Fixes element-hq#24059.
* Fix checkForPreJoinUISI for thread roots ([\element-hq#9803](matrix-org/matrix-react-sdk#9803)). Fixes element-hq#24054.
* Load RTE components only when RTE labs is enabled ([\element-hq#9804](matrix-org/matrix-react-sdk#9804)).
* Fix issue where thread panel did not update correctly ([\element-hq#9746](matrix-org/matrix-react-sdk#9746)). Fixes element-hq#23971.
* Remove async call to get virtual room from room load ([\element-hq#9743](matrix-org/matrix-react-sdk#9743)). Fixes element-hq#23968.
* Check each thread for unread messages. ([\element-hq#9723](matrix-org/matrix-react-sdk#9723)).
* Device manage - handle sessions that don't support encryption ([\element-hq#9717](matrix-org/matrix-react-sdk#9717)). Fixes element-hq#23722.
* Fix hover state for formatting buttons (Rich text editor) (fix element-hq/issues/23832) ([\element-hq#9715](matrix-org/matrix-react-sdk#9715)).
* Don't allow group calls to be unterminated ([\element-hq#9710](matrix-org/matrix-react-sdk#9710)).
* Fix replies to emotes not showing as inline ([\element-hq#9707](matrix-org/matrix-react-sdk#9707)). Fixes element-hq#23903.
* Update copy of 'Change layout' button to match Element Call ([\element-hq#9703](matrix-org/matrix-react-sdk#9703)).
* Fix call splitbrains when switching between rooms ([\element-hq#9692](matrix-org/matrix-react-sdk#9692)).
* bugfix: fix an issue where the Notifier would incorrectly fire for non-timeline events ([\element-hq#9664](matrix-org/matrix-react-sdk#9664)). Fixes element-hq#17263.
* Fix power selector being wrongly disabled for admins themselves ([\element-hq#9681](matrix-org/matrix-react-sdk#9681)). Fixes element-hq#23882.
* Show day counts in call durations ([\element-hq#9641](matrix-org/matrix-react-sdk#9641)).
@t3chguy t3chguy mentioned this issue Sep 15, 2023
Closed
@joerglohrer
Copy link

So this is still stuck :-( How can i contribute to get a view on all names of people reacting?
I think this is essential and many users can't use reactions for simple votings as often used on discord and other plattforms or have to switch to mobile apps to see results in element.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chillmastonmuutos chillmastonmuutos

Labels
A-Aggregations A-Reactions O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist T-Enhancement X-Needs-Design
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
9 participants
@jryans @germain-gg @joerglohrer @turt2live @lampholder @nadonomy @babolivier @SimonBrandner @chillmastonmuutos