Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Visual highlight for autocomplete missing #9134

Closed
jryans opened this issue Mar 12, 2019 · 2 comments
Closed

Visual highlight for autocomplete missing #9134

jryans opened this issue Mar 12, 2019 · 2 comments
Assignees
@jryans
Labels
P2 S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Regression

Comments

@jryans
Copy link
Collaborator

jryans commented Mar 12, 2019

There is a pretty important bug in the latest 1.0.x releases: we don't see which smiley is currently selected any more. So we just need to hit tab until we get the right one.

Originally posted by @MightyCreak in #1107 (comment)
jryans added a commit to jryans/matrix-react-sdk that referenced this issue Mar 12, 2019
@jryans
Use a distinct color for selected autocomplete items
a719839 
This restores the ability to see which autocomplete item is selected (which
seems to have gotten lost during redesign).

Fixes element-hq/element-web#9134
@jryans jryans self-assigned this Mar 12, 2019
@jryans jryans mentioned this issue Mar 12, 2019
Merged
@jryans jryans added T-Defect ui/ux P2 X-Regression S-Minor Impairs non-critical functionality or suitable workarounds exist labels Mar 12, 2019
@MightyCreak
Copy link

Wow, that was fast! Thank you! 😍

@jryans
Copy link
Collaborator Author

jryans commented Mar 13, 2019

Thanks for bringing it to our attention. 😁

@jryans jryans removed the Z-UI/UX label Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jryans jryans

Labels
P2 S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Regression
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jryans @MightyCreak