Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decide if we're keeping tinting support (and at what levels) #8421

Closed
turt2live opened this issue Feb 6, 2019 · 7 comments
Closed

Decide if we're keeping tinting support (and at what levels) #8421

turt2live opened this issue Feb 6, 2019 · 7 comments
Labels
T-Task Tasks for the team like planning X-Needs-Design

Comments

@turt2live
Copy link
Member

ref matrix-org/matrix-react-sdk#2554 (comment)

@RosinSmoke
Copy link

Hello. I really liked old green theme in dark mode, but colour scheme picking is removed at this moment. Are there any plans on returning it, or, at least, adding field in settings for custom css or 5-7 pre-defined palettes? Most of popular chat applications are lacking custom colour schemes, and I thought this feature would stay in Riot because it was really handy, green was easier on my eyes than current shade of blue.

This was referenced Feb 26, 2019
@aaronraimist
Copy link
Collaborator

aaronraimist commented Sep 22, 2019

@jryans replying to your comment from #8950:

The status of tinting is currently unclear. I think I'll mark this as a duplicate of #8421 for now. The reference there should remind us to do this (if decision is to remove it entirely).

It is clear that it doesn't work though so the command at least needs to be removed as an option while the decision is being made.

See https://matrix.to/#/!YTvKGNlinIzlkMTVRl:matrix.org/$vQdghl8gO9zl-Uut4jE3vQaREoXl8XvL3fsty9rw12k?via=matrix.org&via=privacytools.io&via=chat.weho.st

@t3chguy
Copy link
Member

t3chguy commented Sep 22, 2019

@aaronraimist
Copy link
Collaborator

@t3chguy that should be in Riot 1.3.6 right? It still shows up for me as an option on riot.im/app

@t3chguy
Copy link
Member

t3chguy commented Sep 23, 2019

It should not, the last few releases cherry-picked changes so it is still waiting to get merged in along with 700+ other commits :D

@aaronraimist
Copy link
Collaborator

aaronraimist commented Mar 7, 2020

Issues that can be closed when you decide to get rid of tinting:
#738
#907
#2038
#2402
#2544
#3139
#3549
#4353
#6228
#6351

I vote yes kill it and to eventually replaced it with a more advanced theming system like #5844

@turt2live
Copy link
Member Author

It's pretty clear that we're not keeping tinting as it stands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Task Tasks for the team like planning X-Needs-Design
Projects
None yet
Development

No branches or pull requests

4 participants