Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Aliases including two underscores are mangled by Markdown, which is *incredibly* annoying #3428

Closed
ara4n opened this issue Mar 14, 2017 · 1 comment
Closed

Aliases including two underscores are mangled by Markdown, which is *incredibly* annoying #3428

ara4n opened this issue Mar 14, 2017 · 1 comment
Labels
P2 S-Minor Impairs non-critical functionality or suitable workarounds exist S-Tolerable Low/no impact on users T-Defect

Comments

@ara4n
Copy link
Member

ara4n commented Mar 14, 2017

Stuff like this is incredibly embarrassing. We could also fix it by picking a more sensible separator for the bridged aliases, i guess.

screen shot 2017-03-14 at 15 42 53
@lampholder lampholder added T-Defect S-Tolerable Low/no impact on users S-Minor Impairs non-critical functionality or suitable workarounds exist P2 labels Mar 15, 2017
lukebarnard1 pushed a commit to matrix-org/matrix-react-sdk that referenced this issue Aug 4, 2017
MD-escape URLs/alises/user IDs prior to parsing markdown
ee18ddb 
So that MD characters in them do not result in formatting being applied.

Fixes element-hq/element-web#3428
Fixes element-hq/element-web#4674
@lukebarnard1 lukebarnard1 mentioned this issue Aug 4, 2017
Merged
@richvdh richvdh mentioned this issue Sep 27, 2017
Closed
@ara4n
Copy link
Member Author

ara4n commented Feb 7, 2018

So matrix-org/matrix-react-sdk#1694 reintroduces this - it turns out that:

#_foonetic_#xkcd:matrix.org is still mangled into #foonetic#xkcd:matrix.org.
I was accidentally testing previously with #_foonetic_xkcd:matrix.org, which is not affected.

argh.

@ara4n ara4n reopened this Feb 7, 2018
@ara4n ara4n mentioned this issue Feb 7, 2018
Closed
@ara4n ara4n mentioned this issue Sep 20, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P2 S-Minor Impairs non-critical functionality or suitable workarounds exist S-Tolerable Low/no impact on users T-Defect
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ara4n @lampholder @lukebarnard1