Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Receiving a mention in an encrypted "Mentions Only" room does not highlight the room red #23885

Closed
turt2live opened this issue Dec 1, 2022 · 2 comments · Fixed by matrix-org/matrix-js-sdk#2937
Closed

Receiving a mention in an encrypted "Mentions Only" room does not highlight the room red #23885

turt2live opened this issue Dec 1, 2022 · 2 comments · Fixed by matrix-org/matrix-js-sdk#2937
Labels
O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect X-Release-Blocker

Comments

@turt2live
Copy link
Member

Steps to reproduce

  1. Be in a room with 3+ people in it (including yourself)
  2. Set the room's notification level to "Mentions Only"
  3. Enable encryption
  4. Get pinged while the room isn't active

Outcome

What did you expect?

For the room to be highlighted red and decorated accordingly.

What happened instead?

I got the notification sound, but the message appeared in the room list as "bold" (dot, no count). It should have been red with a count.

Operating system

Windows 10

Application version

Nightly (2022-12-01)

How did you install the app?

The Internet

Homeserver

t2l.io

Will you send logs?

Yes
@turt2live
Copy link
Member Author

confirmed to not affect the current staging.element.io deployment

@t3chguy t3chguy mentioned this issue Dec 1, 2022
Merged
@t3chguy
Copy link
Member

t3chguy commented Dec 1, 2022

Release blocker for for 1.11.17

@germain-gg germain-gg mentioned this issue Dec 2, 2022
Merged
3 tasks
@t3chguy t3chguy mentioned this issue Dec 2, 2022
Closed
su-ex added a commit to SchildiChat/matrix-js-sdk that referenced this issue Dec 6, 2022
@su-ex
Merge tag 'v22.0.0' into sc
789e2bf 
* Enable users to join group calls from multiple devices ([\matrix-org#2902](matrix-org#2902)).
* Deprecate a function containing a typo ([\matrix-org#2904](matrix-org#2904)).
* sliding sync: add receipts extension ([\matrix-org#2912](matrix-org#2912)).
* Define a spec support policy for the js-sdk ([\matrix-org#2882](matrix-org#2882)).
* Further improvements to e2ee logging ([\matrix-org#2900](matrix-org#2900)).
* sliding sync: add support for typing extension ([\matrix-org#2893](matrix-org#2893)).
* Improve logging on Olm session errors ([\matrix-org#2885](matrix-org#2885)).
* Improve logging of e2ee messages ([\matrix-org#2884](matrix-org#2884)).
* Fix 3pid invite acceptance not working due to mxid being sent in body ([\matrix-org#2907](matrix-org#2907)). Fixes element-hq/element-web#23823.
* Don't hang up calls that haven't started yet ([\matrix-org#2898](matrix-org#2898)).
* Read receipt accumulation for threads ([\matrix-org#2881](matrix-org#2881)).
* Make GroupCall work better with widgets ([\matrix-org#2935](matrix-org#2935)).
* Fix highlight notifications increasing when total notification is zero ([\matrix-org#2937](matrix-org#2937)). Fixes element-hq/element-web#23885.
* Fix synthesizeReceipt ([\matrix-org#2916](matrix-org#2916)). Fixes element-hq/element-web#23827 element-hq/element-web#23754 and element-hq/element-web#23847.
@kittykat kittykat added S-Major Severely degrades major functionality or product features, with no satisfactory workaround O-Occasional Affects or can be seen by some users regularly or most users rarely labels Dec 8, 2022
su-ex added a commit to SchildiChat/matrix-js-sdk that referenced this issue Jan 15, 2023
@su-ex
Merge tag 'v23.0.0' into sc
b9afe23 
* Process `m.room.encryption` events before emitting `RoomMember` events ([\matrix-org#2914](matrix-org#2914)). Fixes element-hq/element-web#23819.
* Don't expose `calls` on `GroupCall` ([\matrix-org#2941](matrix-org#2941)).
* Support MSC3391: Account data deletion ([\matrix-org#2967](matrix-org#2967)).
* Add a message ID on each to-device message ([\matrix-org#2938](matrix-org#2938)).
* Enable multiple users' power levels to be set at once ([\matrix-org#2892](matrix-org#2892)). Contributed by @GoodGuyMarco.
* Include pending events in thread summary and count again ([\matrix-org#2922](matrix-org#2922)). Fixes element-hq/element-web#23642.
* Make GroupCall work better with widgets ([\matrix-org#2935](matrix-org#2935)).
* Add method to get outgoing room key requests for a given event ([\matrix-org#2930](matrix-org#2930)).
* Fix messages loaded during initial fetch ending up out of order ([\matrix-org#2971](matrix-org#2971)). Fixes element-hq/element-web#23972.
* Fix #23919: Root message for new thread loaded from network ([\matrix-org#2965](matrix-org#2965)). Fixes element-hq/element-web#23919.
* Fix #23916: Prevent edits of the last message in a thread getting lost ([\matrix-org#2951](matrix-org#2951)). Fixes element-hq/element-web#23916 and element-hq/element-web#23942.
* Fix infinite loop when restoring cached read receipts ([\matrix-org#2963](matrix-org#2963)). Fixes element-hq/element-web#23951.
* Don't swallow errors coming from the shareSession call ([\matrix-org#2962](matrix-org#2962)). Fixes element-hq/element-web#23792.
* Make sure that MegolmEncryption.setupPromise always resolves  ([\matrix-org#2960](matrix-org#2960)).
* Do not calculate highlight notifs for threads unknown to the room ([\matrix-org#2957](matrix-org#2957)).
* Cache read receipts for unknown threads ([\matrix-org#2953](matrix-org#2953)).
* bugfix: sliding sync initial room timelines shouldn't notify ([\matrix-org#2933](matrix-org#2933)).
* Redo key sharing after own device verification ([\matrix-org#2921](matrix-org#2921)). Fixes element-hq/element-web#23333.
* Move updated threads to the end of the thread list ([\matrix-org#2923](matrix-org#2923)). Fixes element-hq/element-web#23876.
* Fix highlight notifications increasing when total notification is zero ([\matrix-org#2937](matrix-org#2937)). Fixes element-hq/element-web#23885.
* Fix synthesizeReceipt ([\matrix-org#2916](matrix-org#2916)). Fixes element-hq/element-web#23827 element-hq/element-web#23754 and element-hq/element-web#23847.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect X-Release-Blocker
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix highlight notifications increasing when total notification is zero matrix-org/matrix-js-sdk
3 participants
@kittykat @turt2live @t3chguy