Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cross-signing feature flag #11219

Closed
dbkr opened this issue Oct 24, 2019 · 5 comments · Fixed by matrix-org/matrix-react-sdk#4655
Closed

Remove cross-signing feature flag #11219

dbkr opened this issue Oct 24, 2019 · 5 comments · Fixed by matrix-org/matrix-react-sdk#4655

Comments

@dbkr
Copy link
Member

dbkr commented Oct 24, 2019

After #11215
After #11218
After #11213
Probably after #11220

We may want to also block this on some or all of the new UI.

  • Remove cross-signing labs flag
  • Always show new post sign-in flow after sign-in
  • Remove 'setup cross-signing button' from key backup section
  • Go to pub
@jryans
Copy link
Collaborator

jryans commented Apr 8, 2020

For release day, I think we'll only go as far as enabling the flag, so moving this to a later phase.

@jryans jryans added phase:4 and removed phase:3 labels Apr 8, 2020
turt2live added a commit to matrix-org/matrix-react-sdk that referenced this issue Apr 15, 2020
Fixes element-hq/element-web#11219

This particular commit is largely untested and unverified. Do not merge without extensive review.
@turt2live
Copy link
Member

For now we've gone a route which turns the labs flag into a setting to get closer to what we want (matrix-org/matrix-react-sdk#4416). matrix-org/matrix-react-sdk#4417 is a demonstration of what it looks like to remove the setting, though is untested and will need updating for the route we're going. When removing the setting, please be sure to clean up newly-dead code.

@jryans jryans changed the title Cross-signing out of labs Remove cross-signing feature flag May 13, 2020
@jryans
Copy link
Collaborator

jryans commented May 20, 2020

It's now safe to remove this feature flag. We may add related admin controls (such as #13705), but this specific flag can be removed.

@jryans
Copy link
Collaborator

jryans commented May 21, 2020

It would be best to land this work in the same release as #13705, so that there's some continuity of admin control for those who want it.

@neilisfragile
Copy link
Member

(not directly blocked on design but inter dependent on #13705)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants