fix: pass in platform to electron-rebuild #8537
Merged
+26
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
temporarily leveraging electron-rebuild repo fork with needed changes, waiting on PR to be accepted upstream
🦋 Changeset detectedLatest commit: 3ec80f2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for car-park-attendant-cleat-11576 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Merged
xyloflake
pushed a commit
to xyloflake/electron-builder
that referenced
this pull request
Oct 2, 2024
Updates to latest electron-rebuild that allows passing in `platform` for prebuilt node modules (previous versions of electron-rebuild had hardcoded `process.platform`) Fixes: electron-userland#8528 electron-userland#8426
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to latest electron-rebuild that allows passing in
platformfor prebuilt node modules (previous versions of electron-rebuild had hardcodedprocess.platform)Fixes: #8528 #8426