-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new validations to manage object_type and metric_type fields #527
Add new validations to manage object_type and metric_type fields #527
Conversation
🌐 Coverage report
|
test integrations |
Created or updated PR in integrations repostiory to test this vesrion. Check elastic/integrations#6948 |
Latest run with integrations, the following packages have failed their check:
These are the errors for each packages:
|
💚 Build Succeeded
Historycc @mrodm |
test integrations |
Created or updated PR in integrations repostiory to test this vesrion. Check elastic/integrations#6948 |
Adding the JSON Patches to remove these validation in previous versions , packages failing running "test integrations" are not due to https://fleet-ci.elastic.co/blue/organizations/jenkins/Ingest-manager%2Fintegrations/detail/PR-6948/3/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Hey @mrodm when is it planned to get this changes available in elastic-package? |
We will prepare releases of package-spec and elastic-package today or tomorrow. |
What does this PR do?
This PR adds new validations to include the cases where
object_type
and/ormetric_type
are set in field definitions.object_type
(new):type
isobject
.metric_type
and anobject_type
aggregate_metric_double
not allowed.object_type
just could have a different value of possible values:metric_type
but it does not define anobject_type
type
just could have these allowed values:This PR allows field definitions like this:
Previously, it was failing with this error:
Why is it important?
This new validation will check that the types of the fields will be the right ones when
metric_type
is set for a field (gauge or counter). Not all types are valid when this is enabled. Based on this docChecklist
test/packages
that prove my change is effective.spec/changelog.yml
.Related issues