Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow opt. space between device-id and colon. #2102

Closed
wants to merge 1 commit into from

Conversation

roderickm
Copy link

fix #2101

@elasticsearch-release
Copy link

Can one of the admins verify this patch?

@wiibaa
Copy link
Contributor

wiibaa commented Dec 3, 2014

@roderickm as 1.5 will use exploded projects/gems, could you please move your PR to https://github.com/logstash-plugins/logstash-patterns-core

@roderickm
Copy link
Author

@wiibaa New PR created at logstash-plugins/logstash-patterns-core#2

@suyograo
Copy link
Contributor

@roderickm
Copy link
Author

CLA signed.

@roderickm
Copy link
Author

The CLA Check is failing despite my signing it over a week ago.

This issue report and contribution were done on my employers' time. After my employer submitted the CLA as a company wanting employees to contribute, I signed the CLA last week using my work address. However, my personal address the primary one on my github account. Perhaps the cla_check verifies only the primary github email address?
screen shot 2015-01-15 at 9 50 17 am

@untergeek
Copy link
Member

Yes, the check depends on your github account email.

—Aaron

On Thu, Jan 15, 2015 at 8:52 AM, roderickm notifications@github.com
wrote:

The CLA Check is failing despite my signing it over a week ago.
This issue report and contribution were done on my employers' time. After my employer submitted the CLA as a company wanting employees to contribute, I signed the CLA last week using my work address. However, my personal address the primary one on my github account. Perhaps the cla_check verifies only the primary github email address?

screen shot 2015-01-15 at 9 50 17 am

Reply to this email directly or view it on GitHub:
#2102 (comment)

@roderickm
Copy link
Author

Thanks, @untergeek. To be clear, the work email address with which I signed the CLA is a secondary address on my github account.

@jordansissel
Copy link
Contributor

For Logstash 1.5.0, we've moved all plugins (and grok patterns) to individual repositories. Can you move this pull request to https://github.com/logstash-plugins/logstash-patterns-core?

This sequence of steps may help you do this migration:

  1. Fork this repository

  2. Clone your fork

    git clone https://github.com/roderickm/logstash.git
  3. Create a branch:

    git checkout -b my-branch-name
  4. Apply the patches from this PR into your branch:

    curl -s https://github.com/elastic/logstash/pull/2102.patch | git am

    This should take your commits from this PR and commit them to your new local branch.

  5. Push!

    git push origin my-branch-name
  6. Open a new PR against https://github.com/logstash-plugins/logstash-patterns-core

  7. Sign the CLA

    Our CLA check indicates that some commit authors have not signed the CLA or are not members of Elasticsearch. See our contributor agreement for more details. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Whitespace in Cisco ASA output breaks firewall pattern
6 participants