-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Task Manager] Using track_total_hits in workload agg #99360
Conversation
Pinging @elastic/kibana-alerting-services (Team:Alerting Services) |
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: cc @ymao1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
* Using track_total_hits in workload agg * Increasing size of terms aggregation
* Using track_total_hits in workload agg * Increasing size of terms aggregation
* Using track_total_hits in workload agg * Increasing size of terms aggregation
Resolves #98624
Summary
track_total_hits: true
to the workload aggregation query in order to get an accurate count of tasks.10
so the aggregation would never return more than 10 task typesTo verify this, I created an Always Firing rule running every 15 seconds and attached some actions to it. Then I let it run for a while to build up the number of tasks. Eventually, doing a
curl -X GET api/task_manager/_health
should return a response like this: