Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[deb/rpm] Generate os package specific kibana.yml #98213

Merged
merged 25 commits into from
Aug 31, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
33f1ece
[deb/rpm] Generate os package specific kibana.yml
jbudz Apr 21, 2021
6467862
verify writes
jbudz Apr 28, 2021
66cd259
verify changes
jbudz Apr 28, 2021
127a6b5
Merge branch 'master' into os/kibana_yml
kibanamachine Apr 28, 2021
3dad550
Merge branch 'master' into os/kibana_yml
kibanamachine May 3, 2021
8980fa6
Merge branch 'master' into os/kibana_yml
kibanamachine May 5, 2021
d569d62
Merge branch 'master' into os/kibana_yml
kibanamachine May 10, 2021
3f6b7c9
Merge branch 'master' into os/kibana_yml
kibanamachine May 10, 2021
4dcd009
Merge branch 'master' into os/kibana_yml
kibanamachine May 11, 2021
0202d0f
Merge branch 'master' into os/kibana_yml
kibanamachine May 14, 2021
08867af
Merge branch 'master' into os/kibana_yml
kibanamachine May 24, 2021
9e7edbf
Merge branch 'master' into os/kibana_yml
kibanamachine May 26, 2021
55f15b1
Merge branch 'master' into os/kibana_yml
kibanamachine Jun 1, 2021
49692f9
Merge branch 'master' into os/kibana_yml
kibanamachine Jun 9, 2021
67a906b
Merge branch 'master' into os/kibana_yml
kibanamachine Jun 16, 2021
39aa285
Merge branch 'master' into os/kibana_yml
kibanamachine Jun 22, 2021
f78fdb6
Merge branch 'master' into os/kibana_yml
kibanamachine Jun 24, 2021
aa3a0ca
Merge branch 'master' into os/kibana_yml
kibanamachine Jun 28, 2021
dac637c
Merge branch 'master' into os/kibana_yml
kibanamachine Jul 6, 2021
a859c3d
Merge branch 'master' into os/kibana_yml
kibanamachine Jul 20, 2021
fca991d
Merge branch 'master' into os/kibana_yml
kibanamachine Jul 26, 2021
e22c352
Merge branch 'master' into os/kibana_yml
kibanamachine Jul 27, 2021
3d1438e
Merge branch 'master' into os/kibana_yml
kibanamachine Aug 16, 2021
3a4eec8
Merge branch 'master' into os/kibana_yml
kibanamachine Aug 24, 2021
f4b0f12
Merge branch 'master' into os/kibana_yml
kibanamachine Aug 30, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/dev/build/build_distributables.ts
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,10 @@ export async function buildDistributables(log: ToolingLog, options: BuildOptions
// control w/ --skip-archives
await run(Tasks.CreateArchives);
}

if (options.createDebPackage || options.createRpmPackage) {
await run(Tasks.CreatePackageConfig);
}
if (options.createDebPackage) {
// control w/ --deb or --skip-os-packages
await run(Tasks.CreateDebPackage);
Expand Down
50 changes: 50 additions & 0 deletions src/dev/build/tasks/os_packages/create_os_package_kibana_yml.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,50 @@
/*
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
* or more contributor license agreements. Licensed under the Elastic License
* 2.0 and the Server Side Public License, v 1; you may not use this file except
* in compliance with, at your election, the Elastic License 2.0 or the Server
* Side Public License, v 1.
*/

import { readFileSync, writeFileSync } from 'fs';
import { resolve } from 'path';
import { Build, Config, mkdirp } from '../../lib';

export async function createOSPackageKibanaYML(config: Config, build: Build) {
const configReadPath = config.resolveFromRepo('config', 'kibana.yml');
const configWriteDir = config.resolveFromRepo('build', 'os_packages', 'config');
const configWritePath = resolve(configWriteDir, 'kibana.yml');

await mkdirp(configWriteDir);

let kibanaYML = readFileSync(configReadPath, { encoding: 'utf8' });

[
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm iffy on this approach, but it does work. I looked into templating kibana.yml while preserving it's relatively static nature. Turning it into a template would remove validity of the yml, leading to more duplication.

Any thoughts here?

[/#pid.file:.*/g, 'pid.file: /run/kibana/kibana.pid'],
[/#logging.dest:.*/g, 'logging.dest: /var/log/kibana/kibana.log'],
].forEach((options) => {
const [regex, setting] = options;
const diff = kibanaYML;
const match = kibanaYML.search(regex) >= 0;
if (match) {
if (typeof setting === 'string') {
kibanaYML = kibanaYML.replace(regex, setting);
}
}

if (!diff.localeCompare(kibanaYML)) {
throw new Error(
`OS package configuration unmodified. Verify match for ${regex} is available`
);
}
});

try {
writeFileSync(configWritePath, kibanaYML, { flag: 'wx' });
} catch (err) {
if (err.code === 'EEXIST') {
return;
}
throw err;
}
}
9 changes: 9 additions & 0 deletions src/dev/build/tasks/os_packages/create_os_package_tasks.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,15 @@
import { Task } from '../../lib';
import { runFpm } from './run_fpm';
import { runDockerGenerator } from './docker_generator';
import { createOSPackageKibanaYML } from './create_os_package_kibana_yml';

export const CreatePackageConfig: Task = {
description: 'Creating OS package kibana.yml',

async run(config, log, build) {
await createOSPackageKibanaYML(config, build);
},
};

export const CreateDebPackage: Task = {
description: 'Creating deb package',
Expand Down
1 change: 1 addition & 0 deletions src/dev/build/tasks/os_packages/run_fpm.ts
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,7 @@ export async function runFpm(
`${resolveWithTrailingSlash(fromBuild('.'))}=/usr/share/kibana/`,

// copy the config directory to /etc/kibana
`${config.resolveFromRepo('build/os_packages/config/kibana.yml')}=/etc/kibana/kibana.yml`,
`${resolveWithTrailingSlash(fromBuild('config'))}=/etc/kibana/`,

// copy the data directory at /var/lib/kibana
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ Environment=KBN_PATH_CONF=/etc/kibana
EnvironmentFile=-/etc/default/kibana
EnvironmentFile=-/etc/sysconfig/kibana

ExecStart=/usr/share/kibana/bin/kibana --logging.dest="/var/log/kibana/kibana.log" --pid.file="/run/kibana/kibana.pid"
ExecStart=/usr/share/kibana/bin/kibana

Restart=on-failure
RestartSec=3
Expand Down