Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Maps] Add shape drawing wizard- creates index only #96913
[Maps] Add shape drawing wizard- creates index only #96913
Changes from 59 commits
5f8aa18
2cbd6b0
a80038a
26ec7bf
8ca809a
f9eeb95
b8eea96
b4f3af0
001c87f
95f8f14
2de30ec
92e17aa
143b24a
e129539
9c5ca16
423e3aa
f238ccb
d450fd1
3d7ad76
b12ad85
576b3d3
cd211f9
4f79738
ceae6d2
bee0fd5
3725859
5200165
2cb1832
4ab4c54
32e4dcf
9579d44
da58916
28ffc5f
2217bc1
fa6fd2e
7d2d5a4
634ede6
a549a1e
5bcd3a9
5035bc5
5e39efb
7cd1482
958cc6a
d3c064d
9529b94
177d5d2
65257a0
69e9393
78c3721
9c817f7
431890a
a5b1b1d
087861a
e2b19c2
09017eb
2dd166d
bc75830
4162876
b25bcae
73f2536
58c84e8
bd783ad
8799716
7706cca
f02a8d4
6107902
4f09cd8
065f745
e4c1c92
0d8c253
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
my 2c the wording should be more generic, but @kmartastic has final call here:
more along the lines of:
title:
Create new document layer
and
description: ```Creates a new index pattern. Can be used to draw shapes and points`.
or something.
We can work on the more integrated wording, when we actually integrate the flow after this PR and the one for the drawing toolbar have merged. But right now, that integration is still todo, so it's a little confusing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see your point, just a little reluctant to touch the wording again on this PR after we got to somewhat of a settling point. I think we'll be iterating on this before pulling out of experimental mode so no need for it to be final at this point. Let me know if you feel strongly though
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's change it, so this PR can standalone and we're not priming it for hypothetical later work.
I'd propose:
^ we can change once we start pulling threads together.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we keep the title shorter? Most of the other card titles are a single word. I really like "draw" so something short.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 to a shorter title, which makes it easier to scan.
For the description how about shortening to:
Also, aren't index patterns being renamed in 7.14?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pass in the below props give users feedback when name is getting validated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thinks this logic needs some rethinking on the
IndexNameForm
side but not sure it fits in this PR. Using that logic above enables the button even when there are errors. Even adding an if statement to check for errors on the callback runs into timing issues that leave the button active with errors in place: