-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Maps] timeslider #96791
Closed
Closed
[Maps] timeslider #96791
Changes from all commits
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
303045d
[maps] timeslider
nreese 47fe821
range control with ticks
nreese c553348
add timeslice to store
nreese 2e036eb
add close button to time slider
nreese 6340845
display time window in slider
nreese bfbffe7
next and previous buttons
nreese a16f58c
preserve range when using next and previous buttons
nreese 1de69e7
use timeslice in ES search
nreese 0b90907
clear timeslice when time range changes or timeslider is closed
nreese cf740d4
time format clean up
nreese db6aca9
esSearcSource.updateDueToTimeslice
nreese 2023f95
mask for timeslice in mb filter
nreese 284b914
replace updateDueToTimeslice with source.maskForTimeslice
nreese 5c9e1cc
pass source data request meta to maskForTimeslice
nreese 551c094
rename maskForTimeslice to canMaskForTimeslice
nreese 9dbca99
get source.canMaskTimeslice working for edge cases
nreese 131e1f6
move getInterval into time utils
nreese d3722cf
canMaskTimeslice tests
nreese 350de35
add timeslice mask field to request meta
nreese c6a2098
tslint
nreese f8f1ed6
getInterval tests
nreese 98bbd55
fix mapbox_styles functional test
nreese a60781d
Merge branch 'master' into timeslider
kibanamachine dfb0393
Merge branch 'timeslider' of github.com:nreese/kibana into timeslider
nreese 1e9af66
fix docvalue_fields functional test
nreese 3a38ae5
fix broken jest tests
nreese 2ca2bdc
Merge branch 'master' into timeslider
kibanamachine 78875bb
pass timesliceMaskConfig to symbol filter expression
nreese c1c13c8
merge with master
nreese add90ad
fix merge conflict
nreese 14cdf38
Merge branch 'master' into timeslider
kibanamachine ea2d163
merge with master
nreese File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm wondering if there is a way we can avoid this. Making the sync-operation async causes this asynciness to cascade. It's added complexity in the rendering, and not 100% sure if we're introducing issues.
e.g. the async should be explicitly handled here
kibana/x-pack/plugins/maps/public/connected_components/mb_map/mb_map.tsx
Lines 133 to 135 in c1c13c8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a similar comment wrt adding
timeslice
as optional param. All the other state propagates with search-filters, timeslice being the exception.Right now, this is because of supporting masking, so it makes sense.
But could we keep track of timeslice state separately? e.g. it's not the only piece of state that is async but needed in styling. E.g. styleMeta is managed async too, but read-out synchronously when styles update.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the main question here imho would be: Can we make
timeslice
not special, and treat it like other parts of the global state required by layers.