Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add structured inputs for editable filters #9509

Closed
wants to merge 5 commits into from
Closed

Add structured inputs for editable filters #9509

wants to merge 5 commits into from

Conversation

lukasolson
Copy link
Member

Replaces #7114.

screenshot 2016-05-02 14 01 20

Tyler Smalley and others added 2 commits May 2, 2016 16:16
Adds structured inputs for editable filters
11af8d0 
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
@lukasolson
Merge branch 'master' into HEAD
a26b952
@lukasolson lukasolson mentioned this pull request Dec 15, 2016
Closed
@lukasolson lukasolson self-assigned this Dec 15, 2016
@tbragin
Copy link
Contributor

tbragin commented Jan 4, 2017

@lukasolson I tried checking this out on top of master and got some optimization errors on startup. Can anyone reproduce that? https://gist.github.com/tbragin/81f1651cce16a485aa593187891c94fa

@lukasolson
Copy link
Member Author

Hmm, not sure, I'll take a look.

@lukasolson
Copy link
Member Author

@tbragin Can you see if you still get those errors? Thanks!

@tbragin
Copy link
Contributor

tbragin commented Jan 5, 2017

@lukasolson Thanks! It works now ;)

@erikanderson
Copy link

So happy to see this, it was the single biggest regression from Kibana 3

@Prazzy
Copy link

Prazzy commented Jan 20, 2017 •
edited
Loading

I tried to simplify the filtering and added below options that end user can easily understand.

screen shot 2017-01-19 at 11 18 28 pm

Example:
screen shot 2017-01-19 at 11 17 08 pm

screen shot 2017-01-19 at 11 29 07 pm

I am planning to move this to Kibana 5 soon and will create the PR.

This was referenced Jan 20, 2017
Closed
Closed
@tbragin
Copy link
Contributor

tbragin commented Jan 23, 2017

Decided to hold off while investigating other approaches.

@tbragin tbragin added stalled and removed discuss WIP Work in progress labels Jan 23, 2017
@lukasolson lukasolson closed this Mar 29, 2017
@xycloud
Copy link

xycloud commented Mar 30, 2017 •
edited
Loading

can this feature showed aside the discover input? then people can search it by just choosing sth

@lukasolson
Copy link
Member Author

See #10976 for updates on this issue.

@Prazzy Prazzy mentioned this pull request Mar 31, 2017
Closed
10 tasks
@lukasolson lukasolson deleted the editable-filters branch March 27, 2018 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@lukasolson lukasolson

Labels
stalled updates_needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lukasolson @tbragin @erikanderson @Prazzy @xycloud