-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Uptime] Migrate to TypeScript project references #90510
Changes from 7 commits
b73060c
f6147f9
ae7bea1
159440c
e513411
51842a6
cf3e479
d934e20
3146d9a
de65d3f
27b536d
a11730b
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -261,7 +261,25 @@ | |
}, | ||
"state": { | ||
"agent": null, | ||
"checks": , | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. A little concerning that this didn't cause anything to break (until now). |
||
"checks": [ | ||
{ | ||
"agent": { "id": "8f9a37fb-573a-4fdc-9895-440a5b39c250", "__typename": "Agent" }, | ||
"container": null, | ||
"kubernetes": null, | ||
"monitor": { | ||
"ip": "127.0.0.1", | ||
"name": "localhost", | ||
"status": "up", | ||
"__typename": "CheckMonitor" | ||
}, | ||
"observer": { | ||
"geo": { "name": null, "location": null, "__typename": "CheckGeo" }, | ||
"__typename": "CheckObserver" | ||
}, | ||
"timestamp": "1570538246143", | ||
"__typename": "Check" | ||
} | ||
], | ||
"geo": null, | ||
"observer": { | ||
"geo": { "name": [], "location": null, "__typename": "StateGeo" }, | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -12,6 +12,13 @@ import { rootReducer } from './reducers'; | |
|
||
export type AppState = ReturnType<typeof rootReducer>; | ||
|
||
type ComposeType = typeof compose; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This was copied from another plugin's solution for providing a global type for redux devtools.
andrewvc marked this conversation as resolved.
Show resolved
Hide resolved
|
||
declare global { | ||
interface Window { | ||
__REDUX_DEVTOOLS_EXTENSION_COMPOSE__: ComposeType; | ||
} | ||
} | ||
|
||
const composeEnhancers = window.__REDUX_DEVTOOLS_EXTENSION_COMPOSE__ || compose; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. i would prefer to use this here, this package is already part of kibana, so it would be easier to use.
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👏 |
||
|
||
const sagaMW = createSagaMiddleware(); | ||
|
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
@@ -0,0 +1,24 @@ | ||||||
{ | ||||||
"extends": "../../../tsconfig.base.json", | ||||||
"compilerOptions": { | ||||||
"composite": true, | ||||||
"outDir": "./target/types", | ||||||
"emitDeclarationOnly": true, | ||||||
"declaration": true, | ||||||
"declarationMap": true | ||||||
}, | ||||||
"include": [ | ||||||
"common/**/*", | ||||||
"public/**/*", | ||||||
"server/**/*", | ||||||
"../../../typings/**/*", | ||||||
"public/**/*.json", | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The glob syntax above appeared to ignore JSON files. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. since there are just two json files, maybe it doesn't make sense to use wildcard pattern There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Sure, we can make it more specific. The drawback will be when someone adds a dependency in the future this will need to be updated each time. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
"server/**/*.json" | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
], | ||||||
"references": [ | ||||||
{ "path": "../alerts/tsconfig.json" }, | ||||||
{ "path": "../ml/tsconfig.json" }, | ||||||
{ "path": "../triggers_actions_ui/tsconfig.json" }, | ||||||
{ "path": "../observability/tsconfig.json" } | ||||||
] | ||||||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The compiler seemed to want these exported individually in the way we were referencing them.