Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Renames significant terms feature to "Correlations" (#88974) #89028

Merged
merged 3 commits into from
Jan 25, 2021
Merged

[APM] Renames significant terms feature to "Correlations" (#88974) #89028

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
03b3897
[APM] Renames significant terms feature to "Correlations" (#88974)
ogupte Jan 21, 2021
dc05d13
fix capitalizations
ogupte Jan 21, 2021
406ad1a
Merge branch 'master' into apm-88974-rename-correlations-feature
kibanamachine Jan 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion x-pack/plugins/apm/common/ui_settings_keys.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,5 @@
* you may not use this file except in compliance with the Elastic License.
*/

export const enableSignificantTerms = 'apm:enableSignificantTerms';
export const enableCorrelations = 'apm:enableCorrelations';
export const enableServiceOverview = 'apm:enableServiceOverview';
2 changes: 1 addition & 1 deletion x-pack/plugins/apm/public/components/app/Correlations/LatencyCorrelations.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ export function LatencyCorrelations() {
<EuiFormRow
fullWidth={true}
label="Field"
helpText="Fields to analyse for significant terms"
helpText="Fields to analyse for correlations"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We didn't put in any i18n when doing the PoC. Should we start adding it here or open an issue to make sure it gets there for GA?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll update #86477 to include the i18n.

Copy link
Member

@sorenlouv sorenlouv Jan 25, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ogupte. That's an oversight on my part when I did the initial POC.

>
<EuiComboBox
fullWidth={true}
Expand Down
10 changes: 5 additions & 5 deletions x-pack/plugins/apm/public/components/app/Correlations/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ import {
import { useHistory } from 'react-router-dom';
import { EuiSpacer } from '@elastic/eui';
import { isActivePlatinumLicense } from '../../../../common/license_check';
import { enableSignificantTerms } from '../../../../common/ui_settings_keys';
import { enableCorrelations } from '../../../../common/ui_settings_keys';
import { useApmPluginContext } from '../../../context/apm_plugin/use_apm_plugin_context';
import { LatencyCorrelations } from './LatencyCorrelations';
import { ErrorCorrelations } from './ErrorCorrelations';
Expand All @@ -35,7 +35,7 @@ export function Correlations() {
const history = useHistory();
const [isFlyoutVisible, setIsFlyoutVisible] = useState(false);
if (
!uiSettings.get(enableSignificantTerms) ||
!uiSettings.get(enableCorrelations) ||
!isActivePlatinumLicense(license)
) {
return null;
Expand All @@ -48,7 +48,7 @@ export function Correlations() {
setIsFlyoutVisible(true);
}}
>
View significant terms
View correlations
</EuiButton>

<EuiSpacer size="s" />
Expand All @@ -62,7 +62,7 @@ export function Correlations() {
>
<EuiFlyoutHeader hasBorder aria-labelledby="correlations-flyout">
<EuiTitle>
<h2 id="correlations-flyout">Significant terms</h2>
<h2 id="correlations-flyout">Correlations</h2>
</EuiTitle>
</EuiFlyoutHeader>
<EuiFlyoutBody>
Expand All @@ -88,7 +88,7 @@ export function Correlations() {
iconType="alert"
>
<p>
Significant terms is an experimental feature and in active
Correlations is an experimental feature and in active
development. Bugs and surprises are to be expected but let us
know your feedback so we can improve it.
</p>
Expand Down
9 changes: 4 additions & 5 deletions x-pack/plugins/apm/server/ui_settings.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,25 +8,24 @@ import { schema } from '@kbn/config-schema';
import { i18n } from '@kbn/i18n';
import { UiSettingsParams } from '../../../../src/core/types';
import {
enableSignificantTerms,
enableCorrelations,
enableServiceOverview,
} from '../common/ui_settings_keys';

/**
* uiSettings definitions for APM.
*/
export const uiSettings: Record<string, UiSettingsParams<boolean>> = {
[enableSignificantTerms]: {
[enableCorrelations]: {
category: ['observability'],
name: i18n.translate('xpack.apm.enableCorrelationsExperimentName', {
defaultMessage: 'APM Significant terms (Platinum required)',
defaultMessage: 'APM correlations (Platinum required)',
}),
value: false,
description: i18n.translate(
'xpack.apm.enableCorrelationsExperimentDescription',
{
defaultMessage:
'Enable the experimental Significant terms feature in APM',
defaultMessage: 'Enable the experimental correlations feature in APM',
}
),
schema: schema.boolean(),
Expand Down