Make toolbar_button a shared component #88386

andreadelrio · 2021-01-14T19:07:48Z

Summary

Turns Lens' toolbar_button into a shared component so that it can be easily used in other parts of Kibana.
Related to [Dashboard] Embeddable Toolbar #85663

Checklist

Delete any items that are not applicable to this PR.

~~- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support~~
~~- [ ] Documentation was added for features that require explanation or tutorials~~

Unit or functional tests were updated or added to match the most common scenarios
Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)
This was checked for cross-browser compatibility

For maintainers

This was checked for breaking API changes and was labeled appropriately

ryankeairns · 2021-01-14T19:12:34Z

@andreadelrio this is a great idea!

I think I know the answer to this question, but for the sake of clarity, this will also be used in the shared embeddable toolbar component as well, correct?

andreadelrio · 2021-01-14T19:14:13Z

@andreadelrio this is a great idea!

I think I know the answer to this question, but for the sake of clarity, this will also be used in the shared embeddable toolbar component as well, correct?

@ryankeairns That's correct! Once this is in I can send a PR against Catherine's branch.

kibanamachine · 2021-01-14T19:15:58Z

⏳ Build in-progress, with failures

continuous-integration/kibana-ci/pull-request
Commit: 9ef6210
This comment will update when the build is complete

Failed CI Steps

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

ryankeairns · 2021-01-14T20:22:35Z

@myasonik this one needs your engineering review on behalf of kibana-design

myasonik

LGTM! 🚀

flash1293 · 2021-01-15T09:31:03Z

@elasticmachine merge upstream

flash1293

Tested Lens and still works as expected - LGTM once green (there seems to be some issue with exporting, it probably makes sense to rename the constants specifically for toolbar button)

… into toolbar_button

cchaos

Thanks @andreadelrio !!!

src/plugins/kibana_react/public/toolbar_button/toolbar_button.scss

lizozom · 2021-01-25T08:41:55Z

@elasticmachine merge upstream

lizozom

Moving the component to Kibana React LGTM

… into toolbar_button

andreadelrio · 2021-01-25T19:18:10Z

@elasticmachine merge upstream

kibanamachine · 2021-01-25T21:11:04Z

💛 Build succeeded, but was flaky

continuous-integration/kibana-ci/pull-request
Commit: 4673146
Flaky suites:
- xpack-kibana-ciGroup5

Test Failures

X-Pack Alerting API Integration Tests.x-pack/test/alerting_api_integration/security_and_spaces/tests/alerting/rbac_legacy·ts.alerting api integration security and spaces enabled Alerts legacy alerts alerts "before all" hook in "alerts"

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has not failed recently on tracked branches

[00:00:00]       │
[00:00:00]         └-: alerting api integration security and spaces enabled
[00:00:00]           └-> "before all" hook
[00:03:58]           └-: Alerts
[00:03:58]             └-> "before all" hook
[00:03:58]             └-: legacy alerts
[00:03:58]               └-> "before all" hook
[00:03:58]               └-> "before all" hook
[00:03:58]                 │ debg creating space
[00:03:59]                 │ debg created space
[00:03:59]                 │ debg creating space
[00:04:00]                 │ debg created space
[00:04:00]                 │ debg creating space
[00:04:01]                 │ debg created space
[00:04:01]                 │ debg creating user no_kibana_privileges
[00:04:01]                 │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-ubuntu-18-tests-xxl-1611602335559306419] added user [no_kibana_privileges]
[00:04:01]                 │ debg created user no_kibana_privileges
[00:04:01]                 │ debg creating role no_kibana_privileges
[00:04:01]                 │ info [o.e.x.s.a.r.TransportPutRoleAction] [kibana-ci-immutable-ubuntu-18-tests-xxl-1611602335559306419] added role [no_kibana_privileges]
[00:04:01]                 │ debg creating user superuser
[00:04:01]                 │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-ubuntu-18-tests-xxl-1611602335559306419] added user [superuser]
[00:04:01]                 │ debg created user superuser
[00:04:01]                 │ debg creating user global_read
[00:04:01]                 │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-ubuntu-18-tests-xxl-1611602335559306419] added user [global_read]
[00:04:01]                 │ debg created user global_read
[00:04:01]                 │ debg creating role global_read_role
[00:04:01]                 │ info [o.e.x.s.a.r.TransportPutRoleAction] [kibana-ci-immutable-ubuntu-18-tests-xxl-1611602335559306419] added role [global_read_role]
[00:04:01]                 │ debg creating user space_1_all
[00:04:01]                 │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-ubuntu-18-tests-xxl-1611602335559306419] added user [space_1_all]
[00:04:01]                 │ debg created user space_1_all
[00:04:01]                 │ debg creating role space_1_all_role
[00:04:01]                 │ info [o.e.x.s.a.r.TransportPutRoleAction] [kibana-ci-immutable-ubuntu-18-tests-xxl-1611602335559306419] added role [space_1_all_role]
[00:04:01]                 │ debg creating user space_1_all_with_restricted_fixture
[00:04:02]                 │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-ubuntu-18-tests-xxl-1611602335559306419] added user [space_1_all_with_restricted_fixture]
[00:04:02]                 │ debg created user space_1_all_with_restricted_fixture
[00:04:02]                 │ debg creating role space_1_all_with_restricted_fixture_role
[00:04:02]                 │ info [o.e.x.s.a.r.TransportPutRoleAction] [kibana-ci-immutable-ubuntu-18-tests-xxl-1611602335559306419] added role [space_1_all_with_restricted_fixture_role]
[00:04:02]                 │ debg creating user space_1_all_alerts_none_actions
[00:04:02]                 │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-ubuntu-18-tests-xxl-1611602335559306419] added user [space_1_all_alerts_none_actions]
[00:04:02]                 │ debg created user space_1_all_alerts_none_actions
[00:04:02]                 │ debg creating role space_1_all_alerts_none_actions_role
[00:04:02]                 │ info [o.e.x.s.a.r.TransportPutRoleAction] [kibana-ci-immutable-ubuntu-18-tests-xxl-1611602335559306419] added role [space_1_all_alerts_none_actions_role]
[00:04:02]               └-: alerts
[00:04:02]                 └-> "before all" hook
[00:04:02]                 └-> "before all" hook
[00:04:02]                   │ info [alerts_legacy] Loading "mappings.json"
[00:04:02]                   │ info [alerts_legacy] Loading "data.json"
[00:04:02]                   │ info [o.e.c.m.MetadataDeleteIndexService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1611602335559306419] [.kibana_1/s8KubA_1QJ-hwC6HLArNHA] deleting index
[00:04:02]                   │ info [alerts_legacy] Deleted existing index [".kibana_1"]
[00:04:02]                   │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1611602335559306419] [.kibana_1] creating index, cause [api], templates [], shards [1]/[0]
[00:04:02]                   │ info [alerts_legacy] Created index ".kibana_1"
[00:04:02]                   │ debg [alerts_legacy] ".kibana_1" settings {"index":{"auto_expand_replicas":"0-1","number_of_replicas":"0","number_of_shards":"1"}}
[00:04:02]                   │ info [o.e.c.m.MetadataDeleteIndexService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1611602335559306419] [.kibana_task_manager_1/8M8kZXnZRIqMMIqUjBol0Q] deleting index
[00:04:02]                   │ info [alerts_legacy] Deleted existing index ".kibana_task_manager_1"
[00:04:02]                   │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1611602335559306419] [.kibana_task_manager] creating index, cause [auto(bulk api)], templates [], shards [1]/[1]
[00:04:02]                   │ info failed to create aliases [{ '.kibana_task_manager': {} }] because ES indicated an index/alias already exists, trying again
[00:04:02]                   │ info [o.e.c.m.MetadataDeleteIndexService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1611602335559306419] [.kibana_1/jhkzcPi7TgiLvvJKVBZ6Rw] deleting index
[00:04:02]                   │ info [alerts_legacy] Deleted existing index [".kibana_1"]
[00:04:02]                   └- ✖ fail: alerting api integration security and spaces enabled Alerts legacy alerts alerts "before all" hook in "alerts"
[00:04:02]                   │      Error: [invalid_alias_name_exception] Invalid alias name [.kibana_task_manager], an index exists with the same name as the alias, with { index_uuid="cX4kudVUS_a76mNRuOkQ1A" & index=".kibana_task_manager" }
[00:04:02]                   │       at respond (/dev/shm/workspace/kibana/node_modules/elasticsearch/src/lib/transport.js:349:15)
[00:04:02]                   │       at checkRespForFailure (/dev/shm/workspace/kibana/node_modules/elasticsearch/src/lib/transport.js:306:7)
[00:04:02]                   │       at HttpConnector.<anonymous> (/dev/shm/workspace/kibana/node_modules/elasticsearch/src/lib/connectors/http.js:173:7)
[00:04:02]                   │       at IncomingMessage.wrapper (/dev/shm/workspace/kibana/node_modules/lodash/lodash.js:4949:19)
[00:04:02]                   │       at endReadableNT (internal/streams/readable.js:1327:12)
[00:04:02]                   │       at processTicksAndRejections (internal/process/task_queues.js:80:21)
[00:04:02]                   │ 
[00:04:02]                   │

Stack Trace

StatusCodeError: [invalid_alias_name_exception] Invalid alias name [.kibana_task_manager], an index exists with the same name as the alias, with { index_uuid="cX4kudVUS_a76mNRuOkQ1A" & index=".kibana_task_manager" }
    at respond (/dev/shm/workspace/kibana/node_modules/elasticsearch/src/lib/transport.js:349:15)
    at checkRespForFailure (/dev/shm/workspace/kibana/node_modules/elasticsearch/src/lib/transport.js:306:7)
    at HttpConnector.<anonymous> (/dev/shm/workspace/kibana/node_modules/elasticsearch/src/lib/connectors/http.js:173:7)
    at IncomingMessage.wrapper (/dev/shm/workspace/kibana/node_modules/lodash/lodash.js:4949:19)
    at endReadableNT (internal/streams/readable.js:1327:12)
    at processTicksAndRejections (internal/process/task_queues.js:80:21) {
  status: 400,
  displayName: 'BadRequest',
  path: '/.kibana_task_manager_1',
  query: {},
  body: {
    error: {
      root_cause: [Array],
      type: 'invalid_alias_name_exception',
      reason: 'Invalid alias name [.kibana_task_manager], an index exists with the same name as the alias',
      index_uuid: 'cX4kudVUS_a76mNRuOkQ1A',
      index: '.kibana_task_manager'
    },
    status: 400
  },
  statusCode: 400,
  response: '{"error":{"root_cause":[{"type":"invalid_alias_name_exception","reason":"Invalid alias name [.kibana_task_manager], an index exists with the same name as the alias","index_uuid":"cX4kudVUS_a76mNRuOkQ1A","index":".kibana_task_manager"}],"type":"invalid_alias_name_exception","reason":"Invalid alias name [.kibana_task_manager], an index exists with the same name as the alias","index_uuid":"cX4kudVUS_a76mNRuOkQ1A","index":".kibana_task_manager"},"status":400}',
  toString: [Function (anonymous)],
  toJSON: [Function (anonymous)]
}

X-Pack Alerting API Integration Tests.x-pack/test/alerting_api_integration/security_and_spaces/tests/alerting/rbac_legacy·ts.alerting api integration security and spaces enabled Alerts legacy alerts alerts "after all" hook in "alerts"

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has not failed recently on tracked branches

[00:00:00]       │
[00:00:00]         └-: alerting api integration security and spaces enabled
[00:00:00]           └-> "before all" hook
[00:03:58]           └-: Alerts
[00:03:58]             └-> "before all" hook
[00:03:58]             └-: legacy alerts
[00:03:58]               └-> "before all" hook
[00:03:58]               └-> "before all" hook
[00:03:58]                 │ debg creating space
[00:03:59]                 │ debg created space
[00:03:59]                 │ debg creating space
[00:04:00]                 │ debg created space
[00:04:00]                 │ debg creating space
[00:04:01]                 │ debg created space
[00:04:01]                 │ debg creating user no_kibana_privileges
[00:04:01]                 │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-ubuntu-18-tests-xxl-1611602335559306419] added user [no_kibana_privileges]
[00:04:01]                 │ debg created user no_kibana_privileges
[00:04:01]                 │ debg creating role no_kibana_privileges
[00:04:01]                 │ info [o.e.x.s.a.r.TransportPutRoleAction] [kibana-ci-immutable-ubuntu-18-tests-xxl-1611602335559306419] added role [no_kibana_privileges]
[00:04:01]                 │ debg creating user superuser
[00:04:01]                 │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-ubuntu-18-tests-xxl-1611602335559306419] added user [superuser]
[00:04:01]                 │ debg created user superuser
[00:04:01]                 │ debg creating user global_read
[00:04:01]                 │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-ubuntu-18-tests-xxl-1611602335559306419] added user [global_read]
[00:04:01]                 │ debg created user global_read
[00:04:01]                 │ debg creating role global_read_role
[00:04:01]                 │ info [o.e.x.s.a.r.TransportPutRoleAction] [kibana-ci-immutable-ubuntu-18-tests-xxl-1611602335559306419] added role [global_read_role]
[00:04:01]                 │ debg creating user space_1_all
[00:04:01]                 │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-ubuntu-18-tests-xxl-1611602335559306419] added user [space_1_all]
[00:04:01]                 │ debg created user space_1_all
[00:04:01]                 │ debg creating role space_1_all_role
[00:04:01]                 │ info [o.e.x.s.a.r.TransportPutRoleAction] [kibana-ci-immutable-ubuntu-18-tests-xxl-1611602335559306419] added role [space_1_all_role]
[00:04:01]                 │ debg creating user space_1_all_with_restricted_fixture
[00:04:02]                 │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-ubuntu-18-tests-xxl-1611602335559306419] added user [space_1_all_with_restricted_fixture]
[00:04:02]                 │ debg created user space_1_all_with_restricted_fixture
[00:04:02]                 │ debg creating role space_1_all_with_restricted_fixture_role
[00:04:02]                 │ info [o.e.x.s.a.r.TransportPutRoleAction] [kibana-ci-immutable-ubuntu-18-tests-xxl-1611602335559306419] added role [space_1_all_with_restricted_fixture_role]
[00:04:02]                 │ debg creating user space_1_all_alerts_none_actions
[00:04:02]                 │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-ubuntu-18-tests-xxl-1611602335559306419] added user [space_1_all_alerts_none_actions]
[00:04:02]                 │ debg created user space_1_all_alerts_none_actions
[00:04:02]                 │ debg creating role space_1_all_alerts_none_actions_role
[00:04:02]                 │ info [o.e.x.s.a.r.TransportPutRoleAction] [kibana-ci-immutable-ubuntu-18-tests-xxl-1611602335559306419] added role [space_1_all_alerts_none_actions_role]
[00:04:02]               └-: alerts
[00:04:02]                 └-> "before all" hook
[00:04:02]                 └-> "before all" hook
[00:04:02]                   │ info [alerts_legacy] Loading "mappings.json"
[00:04:02]                   │ info [alerts_legacy] Loading "data.json"
[00:04:02]                   │ info [o.e.c.m.MetadataDeleteIndexService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1611602335559306419] [.kibana_1/s8KubA_1QJ-hwC6HLArNHA] deleting index
[00:04:02]                   │ info [alerts_legacy] Deleted existing index [".kibana_1"]
[00:04:02]                   │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1611602335559306419] [.kibana_1] creating index, cause [api], templates [], shards [1]/[0]
[00:04:02]                   │ info [alerts_legacy] Created index ".kibana_1"
[00:04:02]                   │ debg [alerts_legacy] ".kibana_1" settings {"index":{"auto_expand_replicas":"0-1","number_of_replicas":"0","number_of_shards":"1"}}
[00:04:02]                   │ info [o.e.c.m.MetadataDeleteIndexService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1611602335559306419] [.kibana_task_manager_1/8M8kZXnZRIqMMIqUjBol0Q] deleting index
[00:04:02]                   │ info [alerts_legacy] Deleted existing index ".kibana_task_manager_1"
[00:04:02]                   │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1611602335559306419] [.kibana_task_manager] creating index, cause [auto(bulk api)], templates [], shards [1]/[1]
[00:04:02]                   │ info failed to create aliases [{ '.kibana_task_manager': {} }] because ES indicated an index/alias already exists, trying again
[00:04:02]                   │ info [o.e.c.m.MetadataDeleteIndexService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1611602335559306419] [.kibana_1/jhkzcPi7TgiLvvJKVBZ6Rw] deleting index
[00:04:02]                   │ info [alerts_legacy] Deleted existing index [".kibana_1"]
[00:04:02]                   └- ✖ fail: alerting api integration security and spaces enabled Alerts legacy alerts alerts "before all" hook in "alerts"
[00:04:02]                   │      Error: [invalid_alias_name_exception] Invalid alias name [.kibana_task_manager], an index exists with the same name as the alias, with { index_uuid="cX4kudVUS_a76mNRuOkQ1A" & index=".kibana_task_manager" }
[00:04:02]                   │       at respond (/dev/shm/workspace/kibana/node_modules/elasticsearch/src/lib/transport.js:349:15)
[00:04:02]                   │       at checkRespForFailure (/dev/shm/workspace/kibana/node_modules/elasticsearch/src/lib/transport.js:306:7)
[00:04:02]                   │       at HttpConnector.<anonymous> (/dev/shm/workspace/kibana/node_modules/elasticsearch/src/lib/connectors/http.js:173:7)
[00:04:02]                   │       at IncomingMessage.wrapper (/dev/shm/workspace/kibana/node_modules/lodash/lodash.js:4949:19)
[00:04:02]                   │       at endReadableNT (internal/streams/readable.js:1327:12)
[00:04:02]                   │       at processTicksAndRejections (internal/process/task_queues.js:80:21)
[00:04:02]                   │ 
[00:04:02]                   │ 
[00:04:02]                   └-> "after all" hook
[00:04:02]                     └- ✖ fail: alerting api integration security and spaces enabled Alerts legacy alerts alerts "after all" hook in "alerts"
[00:04:02]                     │      Error: [index_not_found_exception] no such index [.kibana-test-authorization], with { resource.type="index_or_alias" & resource.id=".kibana-test-authorization" & index_uuid="_na_" & index=".kibana-test-authorization" }
[00:04:02]                     │       at respond (/dev/shm/workspace/kibana/node_modules/elasticsearch/src/lib/transport.js:349:15)
[00:04:02]                     │       at checkRespForFailure (/dev/shm/workspace/kibana/node_modules/elasticsearch/src/lib/transport.js:306:7)
[00:04:02]                     │       at HttpConnector.<anonymous> (/dev/shm/workspace/kibana/node_modules/elasticsearch/src/lib/connectors/http.js:173:7)
[00:04:02]                     │       at IncomingMessage.wrapper (/dev/shm/workspace/kibana/node_modules/lodash/lodash.js:4949:19)
[00:04:02]                     │       at endReadableNT (internal/streams/readable.js:1327:12)
[00:04:02]                     │       at processTicksAndRejections (internal/process/task_queues.js:80:21)
[00:04:02]                     │ 
[00:04:02]                     │

Stack Trace

StatusCodeError: [index_not_found_exception] no such index [.kibana-test-authorization], with { resource.type="index_or_alias" & resource.id=".kibana-test-authorization" & index_uuid="_na_" & index=".kibana-test-authorization" }
    at respond (/dev/shm/workspace/kibana/node_modules/elasticsearch/src/lib/transport.js:349:15)
    at checkRespForFailure (/dev/shm/workspace/kibana/node_modules/elasticsearch/src/lib/transport.js:306:7)
    at HttpConnector.<anonymous> (/dev/shm/workspace/kibana/node_modules/elasticsearch/src/lib/connectors/http.js:173:7)
    at IncomingMessage.wrapper (/dev/shm/workspace/kibana/node_modules/lodash/lodash.js:4949:19)
    at endReadableNT (internal/streams/readable.js:1327:12)
    at processTicksAndRejections (internal/process/task_queues.js:80:21) {
  status: 404,
  displayName: 'NotFound',
  path: '/.kibana-test-authorization',
  query: {},
  body: {
    error: {
      root_cause: [Array],
      type: 'index_not_found_exception',
      reason: 'no such index [.kibana-test-authorization]',
      'resource.type': 'index_or_alias',
      'resource.id': '.kibana-test-authorization',
      index_uuid: '_na_',
      index: '.kibana-test-authorization'
    },
    status: 404
  },
  statusCode: 404,
  response: '{"error":{"root_cause":[{"type":"index_not_found_exception","reason":"no such index [.kibana-test-authorization]","resource.type":"index_or_alias","resource.id":".kibana-test-authorization","index_uuid":"_na_","index":".kibana-test-authorization"}],"type":"index_not_found_exception","reason":"no such index [.kibana-test-authorization]","resource.type":"index_or_alias","resource.id":".kibana-test-authorization","index_uuid":"_na_","index":".kibana-test-authorization"},"status":404}',
  toString: [Function (anonymous)],
  toJSON: [Function (anonymous)]
}

X-Pack Alerting API Integration Tests.x-pack/test/alerting_api_integration/security_and_spaces/tests/alerting/index·ts.alerting api integration security and spaces enabled Alerts legacy alerts "after all" hook in "legacy alerts"

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has not failed recently on tracked branches

[00:00:00]       │
[00:00:00]         └-: alerting api integration security and spaces enabled
[00:00:00]           └-> "before all" hook
[00:03:58]           └-: Alerts
[00:03:58]             └-> "before all" hook
[00:03:58]             └-: legacy alerts
[00:03:58]               └-> "before all" hook
[00:03:58]               └-> "before all" hook
[00:03:58]                 │ debg creating space
[00:03:59]                 │ debg created space
[00:03:59]                 │ debg creating space
[00:04:00]                 │ debg created space
[00:04:00]                 │ debg creating space
[00:04:01]                 │ debg created space
[00:04:01]                 │ debg creating user no_kibana_privileges
[00:04:01]                 │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-ubuntu-18-tests-xxl-1611602335559306419] added user [no_kibana_privileges]
[00:04:01]                 │ debg created user no_kibana_privileges
[00:04:01]                 │ debg creating role no_kibana_privileges
[00:04:01]                 │ info [o.e.x.s.a.r.TransportPutRoleAction] [kibana-ci-immutable-ubuntu-18-tests-xxl-1611602335559306419] added role [no_kibana_privileges]
[00:04:01]                 │ debg creating user superuser
[00:04:01]                 │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-ubuntu-18-tests-xxl-1611602335559306419] added user [superuser]
[00:04:01]                 │ debg created user superuser
[00:04:01]                 │ debg creating user global_read
[00:04:01]                 │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-ubuntu-18-tests-xxl-1611602335559306419] added user [global_read]
[00:04:01]                 │ debg created user global_read
[00:04:01]                 │ debg creating role global_read_role
[00:04:01]                 │ info [o.e.x.s.a.r.TransportPutRoleAction] [kibana-ci-immutable-ubuntu-18-tests-xxl-1611602335559306419] added role [global_read_role]
[00:04:01]                 │ debg creating user space_1_all
[00:04:01]                 │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-ubuntu-18-tests-xxl-1611602335559306419] added user [space_1_all]
[00:04:01]                 │ debg created user space_1_all
[00:04:01]                 │ debg creating role space_1_all_role
[00:04:01]                 │ info [o.e.x.s.a.r.TransportPutRoleAction] [kibana-ci-immutable-ubuntu-18-tests-xxl-1611602335559306419] added role [space_1_all_role]
[00:04:01]                 │ debg creating user space_1_all_with_restricted_fixture
[00:04:02]                 │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-ubuntu-18-tests-xxl-1611602335559306419] added user [space_1_all_with_restricted_fixture]
[00:04:02]                 │ debg created user space_1_all_with_restricted_fixture
[00:04:02]                 │ debg creating role space_1_all_with_restricted_fixture_role
[00:04:02]                 │ info [o.e.x.s.a.r.TransportPutRoleAction] [kibana-ci-immutable-ubuntu-18-tests-xxl-1611602335559306419] added role [space_1_all_with_restricted_fixture_role]
[00:04:02]                 │ debg creating user space_1_all_alerts_none_actions
[00:04:02]                 │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-ubuntu-18-tests-xxl-1611602335559306419] added user [space_1_all_alerts_none_actions]
[00:04:02]                 │ debg created user space_1_all_alerts_none_actions
[00:04:02]                 │ debg creating role space_1_all_alerts_none_actions_role
[00:04:02]                 │ info [o.e.x.s.a.r.TransportPutRoleAction] [kibana-ci-immutable-ubuntu-18-tests-xxl-1611602335559306419] added role [space_1_all_alerts_none_actions_role]
[00:04:02]                   └-> "after all" hook
[00:04:02]                     │ debg deleting user no_kibana_privileges
[00:04:02]                     │ debg deleted user no_kibana_privileges
[00:04:02]                     │ debg deleting role no_kibana_privileges
[00:04:02]                     │ debg deleting user superuser
[00:04:02]                     │ debg deleted user superuser
[00:04:02]                     │ debg deleting user global_read
[00:04:02]                     │ debg deleted user global_read
[00:04:02]                     │ debg deleting role global_read_role
[00:04:02]                     │ debg deleting user space_1_all
[00:04:02]                     │ debg deleted user space_1_all
[00:04:02]                     │ debg deleting role space_1_all_role
[00:04:02]                     │ debg deleting user space_1_all_with_restricted_fixture
[00:04:02]                     │ debg deleted user space_1_all_with_restricted_fixture
[00:04:02]                     │ debg deleting role space_1_all_with_restricted_fixture_role
[00:04:02]                     │ debg deleting user space_1_all_alerts_none_actions
[00:04:02]                     │ debg deleted user space_1_all_alerts_none_actions
[00:04:02]                     │ debg deleting role space_1_all_alerts_none_actions_role
[00:04:03]                     │ info [empty_kibana] Unloading indices from "mappings.json"
[00:04:03]                     └- ✖ fail: alerting api integration security and spaces enabled Alerts legacy alerts "after all" hook in "legacy alerts"
[00:04:03]                     │      Error: [index_not_found_exception] no such index [.kibana], with { resource.type="index_or_alias" & resource.id=".kibana" & index_uuid="_na_" & index=".kibana" }
[00:04:03]                     │       at respond (/dev/shm/workspace/kibana/node_modules/elasticsearch/src/lib/transport.js:349:15)
[00:04:03]                     │       at checkRespForFailure (/dev/shm/workspace/kibana/node_modules/elasticsearch/src/lib/transport.js:306:7)
[00:04:03]                     │       at HttpConnector.<anonymous> (/dev/shm/workspace/kibana/node_modules/elasticsearch/src/lib/connectors/http.js:173:7)
[00:04:03]                     │       at IncomingMessage.wrapper (/dev/shm/workspace/kibana/node_modules/lodash/lodash.js:4949:19)
[00:04:03]                     │       at endReadableNT (internal/streams/readable.js:1327:12)
[00:04:03]                     │       at processTicksAndRejections (internal/process/task_queues.js:80:21)
[00:04:03]                     │ 
[00:04:03]                     │

Stack Trace

StatusCodeError: [index_not_found_exception] no such index [.kibana], with { resource.type="index_or_alias" & resource.id=".kibana" & index_uuid="_na_" & index=".kibana" }
    at respond (/dev/shm/workspace/kibana/node_modules/elasticsearch/src/lib/transport.js:349:15)
    at checkRespForFailure (/dev/shm/workspace/kibana/node_modules/elasticsearch/src/lib/transport.js:306:7)
    at HttpConnector.<anonymous> (/dev/shm/workspace/kibana/node_modules/elasticsearch/src/lib/connectors/http.js:173:7)
    at IncomingMessage.wrapper (/dev/shm/workspace/kibana/node_modules/lodash/lodash.js:4949:19)
    at endReadableNT (internal/streams/readable.js:1327:12)
    at processTicksAndRejections (internal/process/task_queues.js:80:21) {
  status: 404,
  displayName: 'NotFound',
  path: '/.kibana/_delete_by_query',
  query: {},
  body: {
    error: {
      root_cause: [Array],
      type: 'index_not_found_exception',
      reason: 'no such index [.kibana]',
      'resource.type': 'index_or_alias',
      'resource.id': '.kibana',
      index_uuid: '_na_',
      index: '.kibana'
    },
    status: 404
  },
  statusCode: 404,
  response: '{"error":{"root_cause":[{"type":"index_not_found_exception","reason":"no such index [.kibana]","resource.type":"index_or_alias","resource.id":".kibana","index_uuid":"_na_","index":".kibana"}],"type":"index_not_found_exception","reason":"no such index [.kibana]","resource.type":"index_or_alias","resource.id":".kibana","index_uuid":"_na_","index":".kibana"},"status":404}',
  toString: [Function (anonymous)],
  toJSON: [Function (anonymous)]
}

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`kibanaReact`	307	318	+11
`lens`	477	467	-10
total			+1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`kibanaReact`	349.9KB	349.9KB	+25.0B
`lens`	1.1MB	1.1MB	-8.7KB
total			-8.7KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`kibanaReact`	124.1KB	134.2KB	+10.1KB

History

💚 Build #100817 succeeded b721d8f
💔 Build #100768 failed b721d8f
💔 Build #100604 failed 7e4d113
💚 Build #99272 succeeded eaba724
💔 Build #99259 failed d5425b5

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

andreadelrio added 4 commits January 12, 2021 17:06

basic version works

036dae2

start replacing with new component

7e8d11c

replaced instances

7cbf470

update snaps

9ef6210

andreadelrio requested a review from a team January 14, 2021 19:07

andreadelrio requested review from a team as code owners January 14, 2021 19:07

andreadelrio added release_note:skip Skip the PR/issue when compiling release notes 8.0.0 v7.12.0 labels Jan 14, 2021

myasonik approved these changes Jan 15, 2021

View reviewed changes

Merge branch 'master' into toolbar_button

8587c69

flash1293 approved these changes Jan 15, 2021

View reviewed changes

andreadelrio added 2 commits January 15, 2021 08:21

renamed member

b731473

Merge branch 'toolbar_button' of https://github.com/andreadelrio/kibana…

498aab5

… into toolbar_button

cchaos reviewed Jan 15, 2021

View reviewed changes

src/plugins/kibana_react/public/toolbar_button/toolbar_button.scss Outdated Show resolved Hide resolved

andreadelrio added 2 commits January 15, 2021 10:58

more specific classnames

d5425b5

update snap

eaba724

wylieconlon added v8.0.0 and removed 8.0.0 labels Jan 20, 2021

Merge branch 'master' into toolbar_button

7e4d113

lizozom approved these changes Jan 25, 2021

View reviewed changes

andreadelrio added 2 commits January 25, 2021 08:17

fix headers

e23adaa

Merge branch 'toolbar_button' of https://github.com/andreadelrio/kibana…

b721d8f

… into toolbar_button

Merge branch 'master' into toolbar_button

4673146

andreadelrio merged commit fb536f5 into elastic:master Jan 25, 2021

andreadelrio mentioned this pull request Jan 25, 2021

[7.x] Make toolbar_button a shared component (#88386) #89240

Merged

andreadelrio added a commit to andreadelrio/kibana that referenced this pull request Jan 25, 2021

Make toolbar_button a shared component (elastic#88386)

a6fbbff

andreadelrio added a commit that referenced this pull request Jan 26, 2021

Make toolbar_button a shared component (#88386) (#89240)

82e10bc

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make toolbar_button a shared component #88386

Make toolbar_button a shared component #88386

andreadelrio commented Jan 14, 2021

ryankeairns commented Jan 14, 2021

andreadelrio commented Jan 14, 2021

kibanamachine commented Jan 14, 2021

ryankeairns commented Jan 14, 2021

myasonik left a comment

flash1293 commented Jan 15, 2021

flash1293 left a comment •

edited

Loading

cchaos left a comment

lizozom commented Jan 25, 2021

lizozom left a comment

andreadelrio commented Jan 25, 2021

kibanamachine commented Jan 25, 2021

Standard Out

Stack Trace

Standard Out

Stack Trace

Standard Out

Stack Trace

Make toolbar_button a shared component #88386

Make toolbar_button a shared component #88386

Conversation

andreadelrio commented Jan 14, 2021

Summary

Checklist

For maintainers

ryankeairns commented Jan 14, 2021

andreadelrio commented Jan 14, 2021

kibanamachine commented Jan 14, 2021

⏳ Build in-progress, with failures

Failed CI Steps

ryankeairns commented Jan 14, 2021

myasonik left a comment

Choose a reason for hiding this comment

flash1293 commented Jan 15, 2021

flash1293 left a comment • edited Loading

Choose a reason for hiding this comment

cchaos left a comment

Choose a reason for hiding this comment

lizozom commented Jan 25, 2021

lizozom left a comment

Choose a reason for hiding this comment

andreadelrio commented Jan 25, 2021

kibanamachine commented Jan 25, 2021

💛 Build succeeded, but was flaky

Test Failures

Standard Out

Stack Trace

Standard Out

Stack Trace

Standard Out

Stack Trace

Metrics [docs]

Module Count

Async chunks

Page load bundle

History

flash1293 left a comment •

edited

Loading