Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[examples] expressions explorer #88344

Merged
merged 6 commits into from
Jan 22, 2021
Merged

[examples] expressions explorer #88344

merged 6 commits into from
Jan 22, 2021

Conversation

ppisljar
Copy link
Member

Summary

Adds expression explorer example plugin

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@ppisljar ppisljar requested review from a team as code owners January 14, 2021 15:38
@botelastic botelastic bot added the Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) label Jan 14, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServices)

@ppisljar ppisljar added 8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.12.0 labels Jan 14, 2021
@ppisljar ppisljar changed the title reporting csv generation from searchSource [examples] expressions explorer Jan 14, 2021
ppisljar
ppisljar commented Jan 19, 2021
View reviewed changes
x-pack/plugins/canvas/canvas_plugin_src/renderers/debug.tsx
handlers.onResize(() => {
ReactDOM.render(renderDebug(), domNode, () => handlers.done());
});
if (handlers.onResize) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@elastic/kibana-presentation this check was added to make it usable outside of canvas

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems pretty straightforward.

streamich
streamich approved these changes Jan 19, 2021
View reviewed changes
Copy link
Contributor

@streamich streamich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested on Mac/Chrome.

examples/expressions_explorer/public/plugin.tsx
}

export class ExpressionsExplorerPlugin implements Plugin<void, void, SetupDeps, StartDeps> {
public setup(core: CoreSetup<StartDeps>, deps: SetupDeps) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: we usually call deps plugins. It does not matter at all, just a bit unexpected.

examples/expressions_explorer/public/plugin.tsx Outdated
appId: 'expressionsExplorer',
title: 'Expressions',
description: `Expressions are ...`,
image,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to remove or update this image, it is ui_actions image.

examples/expressions_explorer/public/plugin.tsx Outdated
deps.developerExamples.register({
appId: 'expressionsExplorer',
title: 'Expressions',
description: `Expressions are ...`,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description: `Expressions are ...`,
description: `Expressions is a plugin that allows to execute Kibana expressions and render content using expression renderers. This example plugin showcases various usage scenarios.`,

@wylieconlon wylieconlon added v8.0.0 and removed 8.0.0 labels Jan 20, 2021
@ppisljar
Copy link
Member Author

@elasticmachine merge upstream

ThomThomson
ThomThomson approved these changes Jan 21, 2021
View reviewed changes
Copy link
Contributor

@ThomThomson ThomThomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Looked through the expressions example plugin. Everything seems to be working as expected. It might be nice to get a few more examples eventually.

x-pack/plugins/canvas/canvas_plugin_src/renderers/debug.tsx
handlers.onResize(() => {
ReactDOM.render(renderDebug(), domNode, () => handlers.done());
});
if (handlers.onResize) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems pretty straightforward.

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
expressions 106 107 +1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
canvas 656.1KB 656.2KB +22.0B
expressions 200.7KB 202.2KB +1.5KB
total +1.5KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@ppisljar ppisljar merged commit d81ab83 into elastic:master Jan 22, 2021
@ppisljar ppisljar mentioned this pull request Jan 22, 2021
Merged
ppisljar added a commit to ppisljar/kibana that referenced this pull request Jan 22, 2021
@ppisljar
[examples] expressions explorer (elastic#88344)
622d880
ppisljar added a commit that referenced this pull request Jan 23, 2021
@ppisljar
[examples] expressions explorer (#88344) (#89065)
d4084f5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@streamich streamich streamich approved these changes

@ThomThomson ThomThomson ThomThomson approved these changes

Assignees
No one assigned
Labels
Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) release_note:skip Skip the PR/issue when compiling release notes v7.12.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ppisljar @elasticmachine @kibanamachine @streamich @ThomThomson @wylieconlon