-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Alerts] ServiceNow SIR Connector #88190
Conversation
a192e05
to
b381eb2
Compare
Pinging @elastic/kibana-alerting-services (Team:Alerting Services) |
30c2f22
to
800d8a6
Compare
Pinging @elastic/uptime (Team:uptime) |
f8ce542
to
d43c63a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Uptime changes LGTM !!
d90ceef
to
764b1d8
Compare
@elasticmachine merge upstream |
9860d51
to
96d40a5
Compare
@elasticmachine merge upstream |
@elasticmachine merge upstream |
...s_ui/public/application/components/builtin_action_types/servicenow/servicenow_sir_params.tsx
Outdated
Show resolved
Hide resolved
@@ -230,9 +234,15 @@ export const ActionForm = ({ | |||
.list() | |||
/** | |||
* TODO: Remove when cases connector is available across Kibana. Issue: https://github.com/elastic/kibana/issues/82502. | |||
* TODO: Need to decide about ServiceNow SIR connector. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
decide what?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The alerting team needs to decide if they gonna support ServiceNow SIR connector for alerts.
...actions_ui/public/application/components/builtin_action_types/servicenow/use_get_choices.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Please make those few updates to the react hooks and you're good to go. I tested locally and it works hooray! 🚀
114fa49
to
eabbb41
Compare
@elasticmachine merge upstream |
@elasticmachine merge upstream |
💔 Build Failed
Failed CI StepsTest FailuresKibana Pipeline / general / Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/ml/data_frame_analytics/cloning·ts.machine learning data frame analytics jobs cloning supported by UI form classification job supported by the form opens the existing job in the data frame analytics job wizardStandard Out
Stack Trace
Kibana Pipeline / general / X-Pack Detection Engine API Integration Tests.x-pack/test/detection_engine_api_integration/security_and_spaces/tests/delete_signals_migrations·ts.detection engine api security and spaces enabled deleting signals migrations rejects the request if the user does not have sufficient privilegesStandard Out
Stack Trace
Kibana Pipeline / general / X-Pack Detection Engine API Integration Tests.x-pack/test/detection_engine_api_integration/security_and_spaces/tests/delete_signals_migrations·ts.detection engine api security and spaces enabled deleting signals migrations rejects the request if the user does not have sufficient privilegesStandard Out
Stack Trace
Metrics [docs]Module Count
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
Summary
Release Notes: Adds ServiceNow SIR Alerting connector
This PR implements a connector for ServiveNow SIR.
Technical details:
servicenow-sir
action type.servicenow-sir
UI.servicenow
andservicenow-sir
use the same service. Both connectors use the Table API. Only the table name changes. It isincident
for ServiceNow Incident Management andsn_si_incident
for ServiceNow SIR. For that reason,createExternalService
accepts the table name as an argument.getChoices: (fields: string[]) => Array<{ value: string; label: string; dependent_value: string; element: string; }>
subaction was created.config
andsecrets
scheme. They differ only in theirparams
.fieldsUrl
to take into account thetask
table.useGetChoices
hook was created to get the choices from the API.fields
from the configuration file of each connector.urgency
,priority
, andseverity
fields of ServiceNow ITSM connector dynamic. They gets their values from thegetChoices
subaction.ServiceNow: Dynamic fields
1.mp4
ServiceNow SIR: Test connector
1.mp4
ServiceNow SIR: Create connector
2.mp4
Meta issue: #82676, https://github.com/elastic/security-team/issues/520
Checklist
Delete any items that are not applicable to this PR.
For maintainers