Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] [Visualize] Remove circular deps between KibanaApp team plugins (#87994) #88141

Merged
merged 1 commit into from
Jan 13, 2021

Conversation

alexwizp
Copy link
Contributor

Backports the following commits to 7.x:

…tic#87994)

* [Visualize] Remove circular deps between KibanaApp team plugins

Part of elastic#84750

* Update use_vis_byvalue.ts

* Update use_saved_vis_instance.ts

* add types

* fix CI

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
visualize 78 80 +2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
visualize 132.4KB 132.7KB +289.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
visDefaultEditor 44.3KB 44.3KB +18.0B
visTypeTimeseries 137.0KB 137.1KB +144.0B
visualizations 171.2KB 171.1KB -62.0B
visualize 42.3KB 43.0KB +654.0B
total +754.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@alexwizp alexwizp merged commit f016285 into elastic:7.x Jan 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants