Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove src/plugins/visualizations -> src/plugins/visualize cyclic dependencies #87797

Merged
merged 2 commits into from
Jan 12, 2021
Merged

Remove src/plugins/visualizations -> src/plugins/visualize cyclic dependencies #87797

merged 2 commits into from
Jan 12, 2021

Conversation

alexwizp
Copy link
Contributor

@alexwizp alexwizp commented Jan 11, 2021 •
edited
Loading

Part of #84750

Summary

Removes circular dependencies between src/plugins/visualizations and src/plugins/visualize plugins.

The dependencies that were removed based on the node scripts/find_plugins_with_circular_deps --debug script.

What was changed in that PR:

  1. EditorRenderProps, IEditorController, VisEditorConstructor types were moved from visualize to visualizations plugin.

@alexwizp alexwizp mentioned this pull request Jan 11, 2021
Closed
5 tasks
@elastic elastic deleted a comment from kibanamachine Jan 11, 2021
@alexwizp alexwizp force-pushed the 86758-4 branch 2 times, most recently from a14aee8 to cd92598 Compare January 11, 2021 09:59
@alexwizp alexwizp self-assigned this Jan 11, 2021
@alexwizp alexwizp added v7.12.0 v8.0.0 Team:Visualizations Visualization editors, elastic-charts and infrastructure release_note:skip Skip the PR/issue when compiling release notes Feature:Visualizations Generic visualization features (in case no more specific feature label is available) labels Jan 11, 2021
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@alexwizp alexwizp marked this pull request as ready for review January 11, 2021 12:33
@alexwizp alexwizp requested a review from a team January 11, 2021 12:33
@alexwizp alexwizp requested a review from a team as a code owner January 11, 2021 12:33
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

mistic
mistic approved these changes Jan 11, 2021
View reviewed changes
Copy link
Member

@mistic mistic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code under Operations team code owners LGTM

stratoula
stratoula approved these changes Jan 12, 2021
View reviewed changes
Copy link
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, since we would like to merge these two plugins in the future it makes sense to move these types to visualizations plugin. I tested it locally and works fine

@alexwizp alexwizp merged commit 7451288 into elastic:master Jan 12, 2021
alexwizp added a commit to alexwizp/kibana that referenced this pull request Jan 12, 2021
@alexwizp
Remove src/plugins/visualizations -> src/plugins/visualize cyclic dep…
cc2d67d 
…endencies (elastic#87797)

* Remove src/plugins/visualizations -> src/plugins/visualize cyclic dependencies

Part of elastic#84750

* fix types
@alexwizp alexwizp mentioned this pull request Jan 12, 2021
Merged
alexwizp added a commit that referenced this pull request Jan 12, 2021
@alexwizp
Remove src/plugins/visualizations -> src/plugins/visualize cyclic dep…
91436b3 
…endencies (#87797) (#87977)

* Remove src/plugins/visualizations -> src/plugins/visualize cyclic dependencies

Part of #84750

* fix types
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mistic mistic mistic approved these changes

@stratoula stratoula stratoula approved these changes

@sulemanof sulemanof Awaiting requested review from sulemanof

Assignees

@alexwizp alexwizp

Labels
Feature:Visualizations Generic visualization features (in case no more specific feature label is available) release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.12.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@alexwizp @kibanamachine @elasticmachine @mistic @stratoula