Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ECS HTTP scheme and improve docs #86612

Merged
merged 1 commit into from
Dec 21, 2020
Merged

Fix ECS HTTP scheme and improve docs #86612

merged 1 commit into from
Dec 21, 2020

Conversation

thomheymann
Copy link
Contributor

Summary

  • Fixes ECS HTTP scheme audit logging (should log http instead of http:)
  • Updated docs with ECS audit schema
  • Removed unused fields from TS interface

Checklist

Delete any items that are not applicable to this PR.

@thomheymann thomheymann added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.11.0 v7.12.0 labels Dec 21, 2020
@thomheymann thomheymann requested a review from a team as a code owner December 21, 2020 09:11
watson
watson approved these changes Dec 21, 2020
View reviewed changes
Copy link
Contributor

@watson watson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well spotted 👍

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Distributable file count

id before after diff
default 47141 47901 +760

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@thomheymann thomheymann merged commit c05533e into elastic:master Dec 21, 2020
thomheymann added a commit to thomheymann/kibana that referenced this pull request Dec 21, 2020
@thomheymann
Fix ECS HTTP scheme and improve docs (elastic#86612)
6066713
@thomheymann thomheymann mentioned this pull request Dec 21, 2020
Merged
thomheymann added a commit to thomheymann/kibana that referenced this pull request Dec 21, 2020
@thomheymann
Fix ECS HTTP scheme and improve docs (elastic#86612)
5677da9
@thomheymann thomheymann mentioned this pull request Dec 21, 2020
Merged
thomheymann added a commit that referenced this pull request Dec 21, 2020
@thomheymann
Fix ECS HTTP scheme and improve docs (#86612) (#86632)
702e795
thomheymann added a commit that referenced this pull request Dec 21, 2020
@thomheymann
Fix ECS HTTP scheme and improve docs (#86612) (#86633)
3e65b72
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@watson watson watson approved these changes

Assignees
No one assigned
Labels
release_note:skip Skip the PR/issue when compiling release notes v7.11.0 v7.12.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thomheymann @kibanamachine @watson