[APM] docs: update agent instructions #85855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmorelli25
added
release_note:skip
|
Pinging @elastic/apm-ui (Team:apm) |
formgeist
requested changes
Dec 15, 2020
There was a problem hiding this comment.
Just want to take out the (default: production) since we're not actually setting a default in the agent config, here we're just suggesting in the snippets that you use something in the config. We'll switch to enforce production as default in a later implementation, we're just not there yet.
src/plugins/apm_oss/server/tutorial/instructions/apm_agent_instructions.ts
Outdated
Show resolved
Hide resolved
src/plugins/apm_oss/server/tutorial/instructions/apm_agent_instructions.ts
Outdated
Show resolved
Hide resolved
src/plugins/apm_oss/server/tutorial/instructions/apm_agent_instructions.ts
Outdated
Show resolved
Hide resolved
src/plugins/apm_oss/server/tutorial/instructions/apm_agent_instructions.ts
Outdated
Show resolved
Hide resolved
src/plugins/apm_oss/server/tutorial/instructions/apm_agent_instructions.ts
Outdated
Show resolved
Hide resolved
src/plugins/apm_oss/server/tutorial/instructions/apm_agent_instructions.ts
Outdated
Show resolved
Hide resolved
src/plugins/apm_oss/server/tutorial/instructions/apm_agent_instructions.ts
Outdated
Show resolved
Hide resolved
src/plugins/apm_oss/server/tutorial/instructions/apm_agent_instructions.ts
Outdated
Show resolved
Hide resolved
src/plugins/apm_oss/server/tutorial/instructions/apm_agent_instructions.ts
Outdated
Show resolved
Hide resolved
|
@axw @felixbarny: Did you have any reservations about adding a default environment to the getting started snippets? |
Co-authored-by: Casper Hübertz <casper@formgeist.com>
💚 Build SucceededMetrics [docs]Distributable file count
History
To update your PR or re-run it, just comment with: |
|
IMO it's fine to add that for now, we can change it later if/when we add a means of setting a configurable default. |
formgeist
approved these changes
Dec 16, 2020
bmorelli25
added a commit
to bmorelli25/kibana
that referenced
this pull request
Dec 16, 2020
Co-authored-by: Casper Hübertz <casper@formgeist.com> Co-authored-by: Casper Hübertz <casper@formgeist.com>
bmorelli25
added a commit
that referenced
this pull request
Dec 16, 2020
bmorelli25
added a commit
that referenced
this pull request
Dec 16, 2020
18 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the APM getting started tutorial snippets for each agent to include the service environment.
I also changed some words here and there to improve consistency between agent instructions.
Related issues
Closes #77739.