Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Monitoring] Add unmapped_type to additional queries #85837

Merged
merged 4 commits into from
Dec 21, 2020
Merged

[Monitoring] Add unmapped_type to additional queries #85837

merged 4 commits into from
Dec 21, 2020

Conversation

chrisronline
Copy link
Contributor

Resolves #85456

In #77099, we missed a few places where we need to add unmapped_type and this PR updates those areas.

@chrisronline chrisronline requested a review from a team December 14, 2020 18:53
@chrisronline chrisronline self-assigned this Dec 14, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/stack-monitoring (Team:Monitoring)

igoristic
igoristic approved these changes Dec 19, 2020
View reviewed changes
Copy link
Contributor

@igoristic igoristic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@chrisronline
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Distributable file count

id before after diff
default 47142 47902 +760

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@chrisronline chrisronline merged commit 805fc4b into elastic:master Dec 21, 2020
@chrisronline chrisronline deleted the monitoring/unmapped branch December 21, 2020 17:00
@chrisronline chrisronline mentioned this pull request Dec 21, 2020
Merged
chrisronline added a commit to chrisronline/kibana that referenced this pull request Dec 21, 2020
@chrisronline @kibanamachine
Fix more sorts by adding unmapped_type (elastic#85837)
6bd6fb4 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@chrisronline chrisronline mentioned this pull request Dec 21, 2020
Merged
chrisronline added a commit to chrisronline/kibana that referenced this pull request Dec 21, 2020
@chrisronline @kibanamachine
Fix more sorts by adding unmapped_type (elastic#85837)
9ad0f13 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
chrisronline added a commit that referenced this pull request Dec 21, 2020
@chrisronline @kibanamachine
Fix more sorts by adding unmapped_type (#85837) (#86666)
7c7dc5f 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
chrisronline added a commit that referenced this pull request Dec 21, 2020
@chrisronline @kibanamachine
Fix more sorts by adding unmapped_type (#85837) (#86667)
6cf7c11 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igoristic igoristic igoristic approved these changes

Assignees

@chrisronline chrisronline

Labels
release_note:fix review Team:Monitoring Stack Monitoring team v7.10.2 v7.11.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Monitoring] Additional queries need unmapped_type
4 participants
@chrisronline @elasticmachine @kibanamachine @igoristic