Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fleet] EPM support to handle uploaded file paths #84708

Merged
merged 5 commits into from
Dec 2, 2020
Merged

[Fleet] EPM support to handle uploaded file paths #84708

merged 5 commits into from
Dec 2, 2020

Conversation

neptunian
Copy link
Contributor

@neptunian neptunian commented Dec 1, 2020 •
edited
Loading

#83855
Modify getFileHandler route handler to return the asset of an uploaded package instead of always reaching out to the registry.

Changes

  • Modify getFileHandler to check the install source, if its uploaded package, check cache, else check registry. This will change later to probably only checking cache, then package storage IF the package is installed

Test uploaded package

Test not installed package (from the registry)

@neptunian neptunian added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.11.0 labels Dec 1, 2020
@neptunian neptunian self-assigned this Dec 1, 2020
@neptunian neptunian force-pushed the 83855-file-route-handles-uploaded-packages branch from 8077f95 to cbd62c7 Compare December 2, 2020 15:27
@neptunian neptunian marked this pull request as ready for review December 2, 2020 15:28
@neptunian neptunian requested a review from a team December 2, 2020 15:28
@neptunian neptunian mentioned this pull request Dec 2, 2020
Closed
jfsiii
jfsiii approved these changes Dec 2, 2020
View reviewed changes
Copy link
Contributor

@jfsiii jfsiii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@botelastic botelastic bot added the Team:Fleet Team label for Observability Data Collection Fleet team label Dec 2, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ingest-management (Team:Ingest Management)

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@neptunian neptunian merged commit a5dd5b6 into elastic:master Dec 2, 2020
@neptunian neptunian mentioned this pull request Dec 2, 2020
Merged
neptunian added a commit to neptunian/kibana that referenced this pull request Dec 2, 2020
@neptunian
[Fleet] EPM support to handle uploaded file paths (elastic#84708)
9413538 
* modify file route to handle uploaded packge file paths

* update messaging

* improve tests

* fix bug and add test to check the version of the uploaded package before failing

* fix similar bug for getting package info from registry when a different version is uploaded
gmmorris added a commit to gmmorris/kibana that referenced this pull request Dec 3, 2020
@gmmorris
Merge branch 'master' into alerts/force-schedule
ffcc5ca 
* master: (40 commits)
  fix: 🐛 don't add separator befor group on no main items (elastic#83166)
  [Security Solution][Detections] Implements indicator match rule cypress test (elastic#84323)
  [APM] Add APM agent config options (elastic#84678)
  Fixed a11y issue on rollup jobs table selection (elastic#84567)
  [Discover] Refactor getContextUrl to separate file (elastic#84503)
  [Embeddable] Export CSV action for Lens embeddables in dashboard (elastic#83654)
  [TSVB] [Cleanup] Remove extra dateFormat props (elastic#84749)
  [Lens] Migrate legacy es client and remove total hits as int (elastic#84340)
  Improve logging pipeline in @kbn/legacy-logging (elastic#84629)
  Catch @hapi/podium errors (elastic#84575)
  [Discover] Unskip date histogram test (elastic#84727)
  Rename server.xsrf.whitelist to server.xsrf.allowlist (elastic#84791)
  [Enterprise Search] Fix schema errors button (elastic#84842)
  [APM] Removes react-sticky dependency in favor of using CSS (elastic#84589)
  [Maps] Always initialize routes on server-startup (elastic#84806)
  [Fleet] EPM support to handle uploaded file paths (elastic#84708)
  [Snapshot Restore] Fix initial policy form state (elastic#83928)
  Upgrade Node.js to version 14 (elastic#83425)
  [Security Solution] Keep Endpoint policies up to date with license changes (elastic#83992)
  [Security Solution][Exceptions] Implement exceptions for ML rules (elastic#84006)
  ...
gmmorris added a commit to gmmorris/kibana that referenced this pull request Dec 3, 2020
@gmmorris
Merge branch 'master' into alerts/flaky-event-log-tests
5cce0f7 
* master: (236 commits)
  fix: 🐛 don't add separator befor group on no main items (elastic#83166)
  [Security Solution][Detections] Implements indicator match rule cypress test (elastic#84323)
  [APM] Add APM agent config options (elastic#84678)
  Fixed a11y issue on rollup jobs table selection (elastic#84567)
  [Discover] Refactor getContextUrl to separate file (elastic#84503)
  [Embeddable] Export CSV action for Lens embeddables in dashboard (elastic#83654)
  [TSVB] [Cleanup] Remove extra dateFormat props (elastic#84749)
  [Lens] Migrate legacy es client and remove total hits as int (elastic#84340)
  Improve logging pipeline in @kbn/legacy-logging (elastic#84629)
  Catch @hapi/podium errors (elastic#84575)
  [Discover] Unskip date histogram test (elastic#84727)
  Rename server.xsrf.whitelist to server.xsrf.allowlist (elastic#84791)
  [Enterprise Search] Fix schema errors button (elastic#84842)
  [APM] Removes react-sticky dependency in favor of using CSS (elastic#84589)
  [Maps] Always initialize routes on server-startup (elastic#84806)
  [Fleet] EPM support to handle uploaded file paths (elastic#84708)
  [Snapshot Restore] Fix initial policy form state (elastic#83928)
  Upgrade Node.js to version 14 (elastic#83425)
  [Security Solution] Keep Endpoint policies up to date with license changes (elastic#83992)
  [Security Solution][Exceptions] Implement exceptions for ML rules (elastic#84006)
  ...
gmmorris added a commit to gmmorris/kibana that referenced this pull request Dec 3, 2020
@gmmorris
Merge remote-tracking branch 'upstream/master' into alerts/custom-rec…
7762864 
…overy-action-group

* upstream/master: (48 commits)
  [Lens] accessibility screen reader issues (elastic#84395)
  [Logs UI] Fetch single log entries via a search strategy (elastic#81710)
  fix: 🐛 don't add separator befor group on no main items (elastic#83166)
  [Security Solution][Detections] Implements indicator match rule cypress test (elastic#84323)
  [APM] Add APM agent config options (elastic#84678)
  Fixed a11y issue on rollup jobs table selection (elastic#84567)
  [Discover] Refactor getContextUrl to separate file (elastic#84503)
  [Embeddable] Export CSV action for Lens embeddables in dashboard (elastic#83654)
  [TSVB] [Cleanup] Remove extra dateFormat props (elastic#84749)
  [Lens] Migrate legacy es client and remove total hits as int (elastic#84340)
  Improve logging pipeline in @kbn/legacy-logging (elastic#84629)
  Catch @hapi/podium errors (elastic#84575)
  [Discover] Unskip date histogram test (elastic#84727)
  Rename server.xsrf.whitelist to server.xsrf.allowlist (elastic#84791)
  [Enterprise Search] Fix schema errors button (elastic#84842)
  [APM] Removes react-sticky dependency in favor of using CSS (elastic#84589)
  [Maps] Always initialize routes on server-startup (elastic#84806)
  [Fleet] EPM support to handle uploaded file paths (elastic#84708)
  [Snapshot Restore] Fix initial policy form state (elastic#83928)
  Upgrade Node.js to version 14 (elastic#83425)
  ...
neptunian added a commit that referenced this pull request Dec 3, 2020
@neptunian
[Fleet] EPM support to handle uploaded file paths (#84708) (#84850)
0794246 
* modify file route to handle uploaded packge file paths

* update messaging

* improve tests

* fix bug and add test to check the version of the uploaded package before failing

* fix similar bug for getting package info from registry when a different version is uploaded
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfsiii jfsiii jfsiii approved these changes

Assignees

@neptunian neptunian

Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v7.11.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@neptunian @elasticmachine @kibanamachine @jfsiii