-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security Solution][Exceptions] Implement exceptions for ML rules #84006
Changes from 1 commit
8525db7
09682d5
7a20f78
50306cb
c5ad7c0
abbc51a
5e5a9b0
87f817e
0b3c064
d52702c
fe820c3
61299d5
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,7 +6,6 @@ | |
|
||
import { flow, omit } from 'lodash/fp'; | ||
import set from 'set-value'; | ||
import { SearchResponse } from 'elasticsearch'; | ||
|
||
import { Logger } from '../../../../../../../src/core/server'; | ||
import { AlertServices } from '../../../../../alerts/server'; | ||
|
@@ -15,6 +14,7 @@ import { RuleTypeParams, RefreshTypes } from '../types'; | |
import { singleBulkCreate, SingleBulkCreateResponse } from './single_bulk_create'; | ||
import { AnomalyResults, Anomaly } from '../../machine_learning'; | ||
import { BuildRuleMessage } from './rule_messages'; | ||
import { SearchResponse } from '../../types'; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I see that we're continuing to diverge from the official typings, but I couldn't find an explanation as to why (I was able to revert these without type errors). If we have an unsupported use case we should probably file an issue upstream. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think I was playing around with the types as well and forgot to switch this one back...got curious about the duplicates There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ah I got an error when changing it back and tracked it down. The search response for KQL query rules is typed based on the custom Need to investigate further why the upstream There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Looks like it was a There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The types package is out of date by over a year. There's an issue to include up-to-date types with the client, but nothing has been merged. We may be better off preferring to use our own There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yeah, this has been an issue for me in the past too. I think we're on our own until those are updated... |
||
|
||
interface BulkCreateMlSignalsParams { | ||
actions: RuleAlertAction[]; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change might be redundant with mine