Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converting vislib to use ES6 syntax #8186

Merged
merged 4 commits into from
Sep 10, 2016
Merged

Conversation

ppisljar
Copy link
Member

@ppisljar ppisljar commented Sep 8, 2016

preparation for future work on vislib

@ppisljar ppisljar added the review label Sep 8, 2016
@ppisljar ppisljar mentioned this pull request Sep 8, 2016
@spalger
Copy link
Contributor

spalger commented Sep 9, 2016

LGTM, tests are passing and the functionality here hasn't changed at all

@Bargs
Copy link
Contributor

Bargs commented Sep 9, 2016

Could we put the commit that converts functions to classes in a separate PR? There are some unresolved arguments about whether we should even recommend classes in our styleguide, so I'd like to resolve those before we start converting everything to class. The rest of the changes look great though so I don't want the class argument to block the rest.

@spalger
Copy link
Contributor

spalger commented Sep 10, 2016

This change is only a small part of the much larger #8174. In that pr, several new1 classes are being defined to replace the classes seen here.

In my eyes, that means these changes are helping to build a comprehensible progression to the final, not a refactor or starting the "converting everything to class" movement. Merging since the "rest of the changes look great".

1: It's pretty obvious that we are fine with new development using class

@spalger spalger merged commit 54ba523 into elastic:master Sep 10, 2016
elastic-jasper added a commit that referenced this pull request Sep 22, 2016
---------

**Commit 1:**
converting to ES6 class syntax

* Original sha: 161ba75
* Authored by ppisljar <peter.pisljar@gmail.com> on 2016-09-08T14:28:44Z

**Commit 2:**
let to const

* Original sha: 9cb6b60
* Authored by ppisljar <peter.pisljar@gmail.com> on 2016-09-08T14:54:41Z

**Commit 3:**
fixing indentation to match our style

* Original sha: 0b63b83
* Authored by ppisljar <peter.pisljar@gmail.com> on 2016-09-08T15:08:56Z

**Commit 4:**
removing unused variables/imports

* Original sha: 9329501
* Authored by ppisljar <peter.pisljar@gmail.com> on 2016-09-08T15:23:24Z
elastic-jasper added a commit that referenced this pull request Sep 22, 2016
---------

**Commit 1:**
converting to ES6 class syntax

* Original sha: 161ba75
* Authored by ppisljar <peter.pisljar@gmail.com> on 2016-09-08T14:28:44Z

**Commit 2:**
let to const

* Original sha: 9cb6b60
* Authored by ppisljar <peter.pisljar@gmail.com> on 2016-09-08T14:54:41Z

**Commit 3:**
fixing indentation to match our style

* Original sha: 0b63b83
* Authored by ppisljar <peter.pisljar@gmail.com> on 2016-09-08T15:08:56Z

**Commit 4:**
removing unused variables/imports

* Original sha: 9329501
* Authored by ppisljar <peter.pisljar@gmail.com> on 2016-09-08T15:23:24Z
This was referenced Sep 22, 2016
ppisljar added a commit that referenced this pull request Sep 22, 2016
---------

**Commit 1:**
converting to ES6 class syntax

* Original sha: 161ba75
* Authored by ppisljar <peter.pisljar@gmail.com> on 2016-09-08T14:28:44Z

**Commit 2:**
let to const

* Original sha: 9cb6b60
* Authored by ppisljar <peter.pisljar@gmail.com> on 2016-09-08T14:54:41Z

**Commit 3:**
fixing indentation to match our style

* Original sha: 0b63b83
* Authored by ppisljar <peter.pisljar@gmail.com> on 2016-09-08T15:08:56Z

**Commit 4:**
removing unused variables/imports

* Original sha: 9329501
* Authored by ppisljar <peter.pisljar@gmail.com> on 2016-09-08T15:23:24Z
ppisljar added a commit that referenced this pull request Sep 22, 2016
---------

**Commit 1:**
converting to ES6 class syntax

* Original sha: 161ba75
* Authored by ppisljar <peter.pisljar@gmail.com> on 2016-09-08T14:28:44Z

**Commit 2:**
let to const

* Original sha: 9cb6b60
* Authored by ppisljar <peter.pisljar@gmail.com> on 2016-09-08T14:54:41Z

**Commit 3:**
fixing indentation to match our style

* Original sha: 0b63b83
* Authored by ppisljar <peter.pisljar@gmail.com> on 2016-09-08T15:08:56Z

**Commit 4:**
removing unused variables/imports

* Original sha: 9329501
* Authored by ppisljar <peter.pisljar@gmail.com> on 2016-09-08T15:23:24Z
ppisljar added a commit that referenced this pull request Sep 22, 2016
ppisljar added a commit that referenced this pull request Sep 22, 2016
airow pushed a commit to airow/kibana that referenced this pull request Feb 16, 2017
---------

**Commit 1:**
converting to ES6 class syntax

* Original sha: 3081ddcf83aeddd8339f1368b677b4f0ae2cd9ec [formerly 161ba75]
* Authored by ppisljar <peter.pisljar@gmail.com> on 2016-09-08T14:28:44Z

**Commit 2:**
let to const

* Original sha: 99bd02b6389a539b23654cca320967c4a9ac393f [formerly 9cb6b60]
* Authored by ppisljar <peter.pisljar@gmail.com> on 2016-09-08T14:54:41Z

**Commit 3:**
fixing indentation to match our style

* Original sha: 13e7932cf0e9a91f037a6f869b4a152d6d590402 [formerly 0b63b83]
* Authored by ppisljar <peter.pisljar@gmail.com> on 2016-09-08T15:08:56Z

**Commit 4:**
removing unused variables/imports

* Original sha: 581c9c5b66150026228e1eb2033109e4436b747c [formerly 9329501]
* Authored by ppisljar <peter.pisljar@gmail.com> on 2016-09-08T15:23:24Z


Former-commit-id: 5b51762
airow pushed a commit to airow/kibana that referenced this pull request Feb 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants