Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Initial TeamCity implementation #81043

Merged
merged 51 commits into from
Nov 20, 2020
Merged

[CI] Initial TeamCity implementation #81043

merged 51 commits into from
Nov 20, 2020

Conversation

brianseeders
Copy link
Contributor

@brianseeders brianseeders commented Oct 19, 2020

This PR provides TeamCity implementations of most of our primary CI pipelines currently running in Jenkins. Namely: Hourly builds for tracked branches, baseline builds, pull requests, and Elasticsearch snapshot build/verify.

See .teamcity/README.md for diagrams and information on how these pipelines are structured.

We reviewed much of this PR as a team during a two-hour video conference.

These pipelines are close to being ready to run, but we need to wait until TeamCity at Elastic is generally available, both to run them and to finalize some of the details. It is likely to be at least two more months before that happens. As such, we discussed merging this PR, and submitting any changes between now and then as separate, smaller PRs.

@brianseeders brianseeders added Team:Operations Team label for Operations Team v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Feature:CI Continuous integration labels Oct 19, 2020
root(Kibana)

checkoutDir = "kibana"
// checkoutDir = "/dev/shm/%system.teamcity.buildType.id%/%system.build.number%/kibana"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this swapped for testing?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"/dev/shm/%system.teamcity.buildType.id%/%system.build.number%/kibana" puts the workspace for the job in memory, but I had some issues when I tried it initially. It's on my TODO list to revisit. It has pretty good performance without being in-memory (probably since a ton of stuff isn't all running on one machine), so it's not a huge concern at the moment.

Copy link
Contributor

@tylersmalley tylersmalley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, including changes to JUnit Reporter and Failed Tests Reporter.

@apmmachine
Copy link
Contributor

💚 Build Succeeded

@brianseeders brianseeders marked this pull request as ready for review November 19, 2020 21:33
@brianseeders brianseeders requested review from a team as code owners November 19, 2020 21:33
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

Copy link
Contributor

@patrykkopycinski patrykkopycinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SIEM/Endpoint LGTM

@brianseeders brianseeders marked this pull request as draft November 19, 2020 23:06
Copy link
Contributor

@spalger spalger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@brianseeders brianseeders marked this pull request as ready for review November 20, 2020 19:30
@brianseeders brianseeders merged commit 314e40f into master Nov 20, 2020
gmmorris added a commit to rudolf/kibana that referenced this pull request Nov 23, 2020
* master: (67 commits)
  [Observability] Load hasData call asynchronously (elastic#80644)
  Implement AnonymousAuthenticationProvider. (elastic#79985)
  Deprecate `visualization:colorMapping` advanced setting (elastic#83372)
  [TSVB] [Rollup] Table tab not working with rollup indexes (elastic#83635)
  Revert "[Search] Search batching using bfetch (elastic#83418)" (elastic#84037)
  skip flaky suite (elastic#83772)
  skip flaky suite (elastic#69849)
  create kbn-legacy-logging package (elastic#77678)
  [Search] Search batching using bfetch (elastic#83418)
  [Security Solution] Refactor Timeline flyout to take a full page (elastic#82033)
  Drop use of console-stamp (elastic#83922)
  skip flaky suite (elastic#84011 , elastic#84012)
  Fixed usage of `isReady` for usage collection of alerts and actions (elastic#83760)
  [maps] support URL drilldowns (elastic#83732)
  Revert "Added default dedupKey value as an {{alertInstanceId}} to provide grouping functionality for PagerDuty incidents. (elastic#83226)"
  [code coverage] Update jest config to collect more data (elastic#83804)
  Added default dedupKey value as an {{alertInstanceId}} to provide grouping functionality for PagerDuty incidents. (elastic#83226)
  [Security Solution] Give notice when endpoint policy is out of date (elastic#83469)
  [Security Solution] Sync url state on any changes to query string (elastic#83314)
  [CI] Initial TeamCity implementation (elastic#81043)
  ...
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Nov 24, 2020
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backported Feature:CI Continuous integration release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v7.11.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants