Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution][Cases] Fix bug with case connectors #80642

Merged
merged 2 commits into from
Oct 16, 2020

Conversation

cnasikas
Copy link
Member

@cnasikas cnasikas commented Oct 15, 2020

Summary

PR #68464 introduced the isCaseOwned configuration attribute to separate action connectors from case connectors. This attributed was added only to ServiceNow connectors. PRs #74357 and #73778 added the same attribute to Jira and IBM resilient. Because #68464 was backported for 7.9 and #74357 and #73778 for 7.10 if a user creates a Jira connector (or IBM Resilient) at 7.9 and then upgrades to 7.10 the Jira connector (or IBM Resilient) will not have the isCaseOwned configuration attribute. As a result, the connector will be filtered out.

This PR fixes this issue.

Ref: #80564

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@cnasikas cnasikas added bug Fixes for quality problems that affect the customer experience Team:SIEM v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.10.0 v7.11.0 Team:Threat Hunting Security Solution Threat Hunting Team labels Oct 15, 2020
@cnasikas cnasikas requested review from a team as code owners October 15, 2020 11:54
@cnasikas cnasikas self-assigned this Oct 15, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/siem (Team:SIEM)

@cnasikas cnasikas added the Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. label Oct 16, 2020
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@cnasikas cnasikas merged commit ca8b038 into elastic:master Oct 16, 2020
@cnasikas cnasikas deleted the fix_upgrade_bug branch October 16, 2020 15:07
cnasikas added a commit to cnasikas/kibana that referenced this pull request Oct 16, 2020
* Fix bug with case connectors

* Improve isCaseOwned function
cnasikas added a commit to cnasikas/kibana that referenced this pull request Oct 16, 2020
* Fix bug with case connectors

* Improve isCaseOwned function
cnasikas added a commit that referenced this pull request Oct 17, 2020
)

* Fix bug with case connectors

* Improve isCaseOwned function
cnasikas added a commit that referenced this pull request Oct 17, 2020
)

* Fix bug with case connectors

* Improve isCaseOwned function
gmmorris added a commit to gmmorris/kibana that referenced this pull request Oct 19, 2020
* master: (51 commits)
  [Discover] Unskip flaky test (elastic#80670)
  Fix security solution template label (elastic#80754)
  [Ingest]: ignore 404, check if there are transforms in results. (elastic#80721)
  Moving loader to logo in header, add a slight 250ms pause (elastic#78879)
  [Security Solution][Cases] Fix bug with case connectors (elastic#80642)
  Update known-plugins.asciidoc (elastic#75388)
  [Lens] Add median operation (elastic#79453)
  Fix navigateToApp logic when navigating to the current app. (elastic#80809)
  [Visualizations] Fix bad color mapping with multiple split series (elastic#80801)
  [ILM] Add esErrorHandler for the new es js client (elastic#80302)
  Fix codeowners (elastic#80826)
  skip flaky suite (elastic#79463)
  [Timelion] Remove kui usage (elastic#80287)
  [Ingest Manager] add skipIfNoDockerRegistry to package_install_complete test (elastic#80779)
  [Alerting UI] Disable "Save" button for Alerts with broken Connectors (elastic#80579)
  Allow the default space to be accessed via `/s/default` (elastic#77109)
  Add script to identify plugin dependencies for TS project references migration (elastic#80463)
  [Search] Client side session service (elastic#76889)
  feat: 🎸 add separator for different context menu groups (elastic#80498)
  Lazy load reporting (elastic#80492)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:SIEM Team:Threat Hunting Security Solution Threat Hunting Team v7.10.0 v7.11.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants