Use SavedObjectClass from savedObject start contract instead of createSavedObjectClass
#80063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgayvallet
changed the title
createSavedObjectClass from savedObject start contractSavedObjectClass from savedObject start contract instead of createSavedObjectClass
41 tasks
pgayvallet
added
Feature:Saved Objects
release_note:skip
…ObjectClass-from-start
…ObjectClass-from-start
kindsun
approved these changes
Oct 12, 2020
flash1293
approved these changes
Oct 13, 2020
…ObjectClass-from-start
💚 Build SucceededMetrics [docs]async chunks size
page load bundle size
History
To update your PR or re-run it, just comment with: |
pgayvallet
added a commit
to pgayvallet/kibana
that referenced
this pull request
Oct 14, 2020
…createSavedObjectClass` (elastic#80063) * no longer export static createSavedObjectClass from savedObject plugin * fix forgotten call * yet another usage * more fixes * move so to required plugins for timelion # Conflicts: # src/plugins/dashboard/public/plugin.tsx # src/plugins/visualizations/kibana.json # src/plugins/visualizations/public/plugin.ts
pgayvallet
added a commit
to pgayvallet/kibana
that referenced
this pull request
Oct 14, 2020
…createSavedObjectClass` (elastic#80063) * no longer export static createSavedObjectClass from savedObject plugin * fix forgotten call * yet another usage * more fixes * move so to required plugins for timelion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
No longer export the static
createSavedObjectClassfunction from thesavedObjectsbundle, and force to use the class (that was already exposed) from thesavedObjectsplugin'sstartcontract instead.Context: In addition to being closer to KP plugins design by consuming the plugin's contract instead of using static exports from the bundle, this is a required preliminary work for #74571 that will require to introduce a decorator registry to the savedObject plugin to allow enhancing the
SavedObjectclass (see #74571 (comment) for the full context)