-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Alerting] add more execution status functional tests #79278
Draft
pmuellr
wants to merge
1
commit into
elastic:main
Choose a base branch
from
pmuellr:alerts/moar-execution-status-tests
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+157
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I remembered some additional functional tests that should have been in PR elastic#75553 One is to ensure the error field gets cleared from the saved object, after the error status is updated with a non-error status. I always worry a bit about partial updates. The other is to do some negative find tests with the new fields. The existing tests are all positive, but would return the same results if for some reason the filters were ignored (presumably a bug). The negative tests ensure the filters actually filter things out as well. Also a bit of refactoring / cleanup of the tests.
pmuellr
force-pushed
the
alerts/moar-execution-status-tests
branch
from
October 2, 2020 20:06
7caf2a6
to
131676a
Compare
💔 Build Failed
Failed CI StepsTest FailuresX-Pack EPM API Integration Tests.x-pack/test/ingest_manager_api_integration/apis/fleet/agents/complete_flow·ts.Ingest Manager Endpoints Fleet Endpoints fleet_agent_flow should workStandard Out
Stack Trace
X-Pack EPM API Integration Tests.x-pack/test/ingest_manager_api_integration/apis/fleet/agents/complete_flow·ts.Ingest Manager Endpoints Fleet Endpoints fleet_agent_flow should workStandard Out
Stack Trace
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
Mohrip
suggested changes
Jul 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
....
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I remembered some additional functional tests that should have been in
PR #75553
One is to ensure the error field gets cleared from the saved object, after
the error status is updated with a non-error status. I always worry a bit
about partial updates.
The other is to do some negative find tests with the new fields. The existing
tests are all positive, but would return the same results if for some reason
the filters were ignored (presumably a bug). The negative tests ensure the
filters actually filter things out as well.
Also a bit of refactoring / cleanup of the tests.