-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix for search due to eui@29.0.0 #77962
Conversation
Pinging @elastic/kibana-core-ui (Team:Core UI) |
x-pack/plugins/global_search_bar/public/components/search_bar.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed tabbing, works as expected. Thanks Dave!
@elasticmachine merge upstream |
Also if you use purely keyboard to focus and search, then it doesn't auto select the first entry in the list. |
💚 Build SucceededBuild metricspage load bundle size
History
To update your PR or re-run it, just comment with: |
@shahzad31 I'll leave that feedback to the core ui team. This was a quick regression fix that I'd like to get to master. |
Friendly reminder: Looks like this PR hasn’t been backported yet. |
@snide Did you backport this? |
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
Summary
This is an implementation fix due to #77802
The new search template has some new requirements around breakpoints and mobile buttons. These props were absent in the upgrade PR and forced the search to have issues with blur states.
Checklist
Delete any items that are not applicable to this PR.
[ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)[ ] Documentation was added for features that require explanation or tutorials[ ] Unit or functional tests were updated or added to match the most common scenariosFor maintainers
[ ] This was checked for breaking API changes and was labeled appropriately