Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Prototype] Add plugin install hook #7613

Closed
wants to merge 2 commits into from
Closed

Conversation

Bargs
Copy link
Contributor

@Bargs Bargs commented Jul 2, 2016

This is a prototype for a plugin install time hook that might be useful for the i18n plugin: #7545

Test it by installing the following example translation plugin:

management-es.zip

@hickeyma
Copy link
Contributor

hickeyma commented Jul 4, 2016

@Bargs Thanks for this.

I have tried it out and it produces the output ("Translation registered at...") when I run plugin install for the 'management' plugin.

It does not seem to be calling 'i18n.registerTranslations' however. I have put in some trace to make sure but not getting any output. Any ideas what I might be missing?

@Bargs
Copy link
Contributor Author

Bargs commented Jul 5, 2016

@hickeyma I'm not using your implementation in my branch. For the sake of simplicity in demonstrating what I'm thinking, I just faked out the i18n plugin.

@hickeyma
Copy link
Contributor

hickeyma commented Jul 6, 2016

@Bargs Sure, understand that. I happened to hook in the actual i18n plugin but missed the mocked registration in the index of i18n module. Your feedback here fixed my issue. Thanks! :-)

@hickeyma hickeyma mentioned this pull request Jul 8, 2016
@epixa
Copy link
Contributor

epixa commented Oct 8, 2016

@Bargs What's the status of this?

@Bargs
Copy link
Contributor Author

Bargs commented Oct 10, 2016

No longer necessary

@Bargs Bargs closed this Oct 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants