Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Time to Visualize] Unifying feature flag config for visualize editor and dashboard #75408

Merged
merged 4 commits into from
Aug 20, 2020
Merged

[Time to Visualize] Unifying feature flag config for visualize editor and dashboard #75408

merged 4 commits into from
Aug 20, 2020

Conversation

majagrubic
Copy link
Contributor

@majagrubic majagrubic commented Aug 19, 2020 •
edited
Loading

Summary

Abandoning previous Visualize plugin FF and making use of the one from Dashboard.
Follow-up on #72256

Checklist

Delete any items that are not applicable to this PR.

- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
- [ ] Documentation was added for features that require explanation or tutorials
- [ ] Unit or functional tests were updated or added to match the most common scenarios
- [ ] This was checked for keyboard-only and screenreader accessibility
- [ ] This renders correctly on smaller devices using a responsive layout. (You can test this in your browser
- [ ] This was checked for cross-browser compatibility

For maintainers

@majagrubic majagrubic marked this pull request as ready for review August 19, 2020 13:35
@majagrubic majagrubic requested a review from a team August 19, 2020 13:35
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

async chunks size

id value diff baseline
visualize 693.9KB +28.0B 693.8KB

page load bundle size

id value diff baseline
visualize 41.3KB -23.0B 41.3KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

ThomThomson
ThomThomson approved these changes Aug 19, 2020
View reviewed changes
Copy link
Contributor

@ThomThomson ThomThomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome,

Tested locally on chrome, the dashboard feature flag now works for visualize!
Code LGTM

@majagrubic majagrubic merged commit be0724d into elastic:master Aug 20, 2020
@majagrubic majagrubic deleted the unified-ff-setting branch August 20, 2020 07:02
@majagrubic majagrubic mentioned this pull request Aug 20, 2020
Merged
majagrubic pushed a commit that referenced this pull request Aug 21, 2020
[Time to Visualize] Unifying feature flag config for visualize editor…
866d8ad 
… and dashboard (#75408) (#75524)

* Unifying feature flag config for visualize/dashboard

* Removing unused import

* Adding missing comma
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThomThomson ThomThomson ThomThomson approved these changes

Assignees
No one assigned
Labels
Feature:Dashboard Dashboard related features v7.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@majagrubic @kibanamachine @ThomThomson