Build artifact names for unified release process #7490

epixa · 2016-06-16T18:01:58Z

These changes are necessary for Kibana to be compatible with Elastic's
unified release process from 5.0 onward. The way artifacts get created
has not changed, but the naming conventions have.

epixa · 2016-06-16T18:23:04Z

/cc @rjernst

jbudz · 2016-06-16T19:32:40Z

tasks/config/platforms.js

      debPath = resolve(rootPath, `target/${debName}`);

-      let rpmArch = name.match('x64') ? 'x86_64' : 'i386';
-      rpmName = `kibana-${version.replace('-', '_')}-1.${rpmArch}.rpm`;
+      let rpmArch = name.match('x64') ? 'x86_64' : 'i686';


we'll have to update https://github.com/epixa/kibana/blob/f7dc301d8ba72b00fc4754630bf970c017e064e8/tasks/build/os_packages.js#L20 too. Might be a better way to centralize the architecture, we can move it to tasks/config/packages.js

jbudz · 2016-06-16T20:42:13Z

» ls target
kibana-5.0.0-alpha4-SNAPSHOT-amd64.deb
kibana-5.0.0-alpha4-SNAPSHOT-i386.deb
kibana-5.0.0-alpha4-SNAPSHOT-i686.rpm
kibana-5.0.0-alpha4-SNAPSHOT-x86_64.rpm

epixa · 2016-06-16T20:43:38Z

I got the same.

jbudz · 2016-06-16T20:45:10Z

Think we need to update the snapshot URLs again 🎱

epixa · 2016-06-16T20:45:28Z

Yep

These changes are necessary for Kibana to be compatible with Elastic's unified release process from 5.0 onward. The way artifacts get created has not changed, but the naming conventions have.

epixa · 2016-06-16T20:47:17Z

Readme links updated

jbudz · 2016-06-16T20:49:55Z

README.md

-| Linux x64 | [tar](http://download.elastic.co/kibana/kibana-snapshot/kibana-5.0.0-SNAPSHOT-linux-x64.tar.gz) [deb](https://download.elastic.co/kibana/kibana-snapshot/kibana_5.0.0-SNAPSHOT_amd64.deb) [rpm](https://download.elastic.co/kibana/kibana-snapshot/kibana-5.0.0_SNAPSHOT-1.x86_64.rpm) |
-| Linux x86 | [tar](http://download.elastic.co/kibana/kibana-snapshot/kibana-5.0.0-SNAPSHOT-linux-x86.tar.gz) [deb](https://download.elastic.co/kibana/kibana-snapshot/kibana_5.0.0-SNAPSHOT_i386.deb) [rpm](https://download.elastic.co/kibana/kibana-snapshot/kibana-5.0.0_SNAPSHOT-1.i386.rpm) |
+| Linux x64 | [tar](http://download.elastic.co/kibana/kibana-snapshot/kibana-5.0.0-SNAPSHOT-linux-x64.tar.gz) [deb](https://download.elastic.co/kibana/kibana-snapshot/kibana-5.0.0-SNAPSHOT-amd64.deb) [rpm](https://download.elastic.co/kibana/kibana-snapshot/kibana-5.0.0-SNAPSHOT-x86_64.rpm) |
+| Linux x86 | [tar](http://download.elastic.co/kibana/kibana-snapshot/kibana-5.0.0-SNAPSHOT-linux-x86.tar.gz) [deb](https://download.elastic.co/kibana/kibana-snapshot/kibana-5.0.0-SNAPSHOT-i386.deb) [rpm](https://download.elastic.co/kibana/kibana-snapshot/kibana-5.0.0-SNAPSHOT-i686.rpm) |


do we want this to say alpha4-snapshot?

Ah crap, the whole readme needs to be updated -alpha4. I was going off of the version at the top of the README, but that wasn't updated when package.json was.

Commit incoming.

We bumped the version in package.json, but we never changed it in the readme.

epixa · 2016-06-16T20:57:04Z

Alright, versions fixed throughout the readme.

jbudz · 2016-06-16T21:16:16Z

LGTM

--------- **Commit 1:** Build artifact names for unified release process These changes are necessary for Kibana to be compatible with Elastic's unified release process from 5.0 onward. The way artifacts get created has not changed, but the naming conventions have. * Original sha: c550bbc * Authored by Court Ewing <court@epixa.com> on 2016-06-16T11:58:31Z **Commit 2:** README is 5.0.0-alpha4 to match package.json We bumped the version in package.json, but we never changed it in the readme. * Original sha: 55c4993 * Authored by Court Ewing <court@epixa.com> on 2016-06-16T20:52:58Z

[backport] PR #7490 to 4.x

Build artifact names for unified release process Former-commit-id: b727ccb

`v92.2.1` ⏩ `v93.0.0` --- ## [`v93.0.0`](https://github.com/elastic/eui/releases/v93.0.0) **Bug fixes** - Fixed `EuiTextTruncate` component to clean up timer from side effect on unmount ([#7495](elastic/eui#7495)) **Breaking changes** - Removed deprecated `anchorClassName` prop from `EuiPopover`. Use `className` instead ([#7488](elastic/eui#7488)) - Removed deprecated `buttonRef` prop from `EuiPopover`. Use `popoverRef` instead ([#7488](elastic/eui#7488)) - Removed deprecated `toolTipTitle` and `toolTipPosition` props from `EuiContextMenuItem`. Use `toolTipProps.title` and `toolTipProps.position` instead ([#7489](elastic/eui#7489)) - Removed deprecated internal `setSelection` ref method from `EuiInMemoryTable` and `EuiBasicTable`. Use the new controlled `selection.selected` prop API instead. ([#7491](elastic/eui#7491)) - `EuiTourStep`'s `className` and `style` props now apply to the anchoring element instead of to the popover panel, to match `EuiPopover` behavior. ([#7497](elastic/eui#7497)) - Convert your existing usages to `panelClassName` and `panelStyle` respectively instead. **Performance** - Improved the amount of recomputed styles being generated by `EuiCode` and `EuiCodeBlock` ([#7486](elastic/eui#7486)) **CSS-in-JS conversions** - Converted `EuiSearchBar` to Emotion ([#7490](elastic/eui#7490)) - Converted `EuiEmptyPrompt` to Emotion ([#7494](elastic/eui#7494)) - Added `euiBorderColor` and `useEuiBorderColorCSS` style utilities ([#7494](elastic/eui#7494)) --------- Co-authored-by: Jon <jon@elastic.co>

`v92.2.1` ⏩ `v93.0.0` --- ## [`v93.0.0`](https://github.com/elastic/eui/releases/v93.0.0) **Bug fixes** - Fixed `EuiTextTruncate` component to clean up timer from side effect on unmount ([elastic#7495](elastic/eui#7495)) **Breaking changes** - Removed deprecated `anchorClassName` prop from `EuiPopover`. Use `className` instead ([elastic#7488](elastic/eui#7488)) - Removed deprecated `buttonRef` prop from `EuiPopover`. Use `popoverRef` instead ([elastic#7488](elastic/eui#7488)) - Removed deprecated `toolTipTitle` and `toolTipPosition` props from `EuiContextMenuItem`. Use `toolTipProps.title` and `toolTipProps.position` instead ([elastic#7489](elastic/eui#7489)) - Removed deprecated internal `setSelection` ref method from `EuiInMemoryTable` and `EuiBasicTable`. Use the new controlled `selection.selected` prop API instead. ([elastic#7491](elastic/eui#7491)) - `EuiTourStep`'s `className` and `style` props now apply to the anchoring element instead of to the popover panel, to match `EuiPopover` behavior. ([elastic#7497](elastic/eui#7497)) - Convert your existing usages to `panelClassName` and `panelStyle` respectively instead. **Performance** - Improved the amount of recomputed styles being generated by `EuiCode` and `EuiCodeBlock` ([elastic#7486](elastic/eui#7486)) **CSS-in-JS conversions** - Converted `EuiSearchBar` to Emotion ([elastic#7490](elastic/eui#7490)) - Converted `EuiEmptyPrompt` to Emotion ([elastic#7494](elastic/eui#7494)) - Added `euiBorderColor` and `useEuiBorderColorCSS` style utilities ([elastic#7494](elastic/eui#7494)) --------- Co-authored-by: Jon <jon@elastic.co>

epixa added blocker review v5.0.0 labels Jun 16, 2016

epixa assigned jbudz Jun 16, 2016

epixa added the v4.6.0 label Jun 16, 2016

jbudz reviewed Jun 16, 2016
View reviewed changes

epixa force-pushed the urp branch from f7dc301 to 0979895 Compare June 16, 2016 20:30

Build artifact names for unified release process

c550bbc

These changes are necessary for Kibana to be compatible with Elastic's unified release process from 5.0 onward. The way artifacts get created has not changed, but the naming conventions have.

epixa force-pushed the urp branch from 0979895 to c550bbc Compare June 16, 2016 20:47

jbudz reviewed Jun 16, 2016
View reviewed changes

README is 5.0.0-alpha4 to match package.json

55c4993

We bumped the version in package.json, but we never changed it in the readme.

epixa merged commit b727ccb into elastic:master Jun 16, 2016

epixa deleted the urp branch June 16, 2016 21:59

epixa added v4.6.0 v5.0.0-alpha4 and removed v4.6.0 labels Jun 16, 2016

epixa added v5.0.0 and removed v5.0.0 labels Jun 28, 2016

elastic-jasper mentioned this pull request Jul 22, 2016

[backport] PR #7490 to 4.x - Build artifact names for unified release process #7809

Merged

epixa added a commit that referenced this pull request Jul 22, 2016

Merge pull request #7809 from elastic/jasper/backport/7490/4.x

91386bd

[backport] PR #7490 to 4.x

airow pushed a commit to airow/kibana that referenced this pull request Feb 16, 2017

Merge pull request elastic#7490 from epixa/urp

4aee171

Build artifact names for unified release process Former-commit-id: b727ccb

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Build artifact names for unified release process #7490

Build artifact names for unified release process #7490

epixa commented Jun 16, 2016

epixa commented Jun 16, 2016

jbudz Jun 16, 2016

epixa Jun 16, 2016

jbudz commented Jun 16, 2016

epixa commented Jun 16, 2016

jbudz commented Jun 16, 2016

epixa commented Jun 16, 2016

epixa commented Jun 16, 2016

jbudz Jun 16, 2016

epixa Jun 16, 2016

epixa commented Jun 16, 2016

jbudz commented Jun 16, 2016

Build artifact names for unified release process #7490

Build artifact names for unified release process #7490

Conversation

epixa commented Jun 16, 2016

epixa commented Jun 16, 2016

jbudz Jun 16, 2016

Choose a reason for hiding this comment

epixa Jun 16, 2016

Choose a reason for hiding this comment

jbudz commented Jun 16, 2016

epixa commented Jun 16, 2016

jbudz commented Jun 16, 2016

epixa commented Jun 16, 2016

epixa commented Jun 16, 2016

jbudz Jun 16, 2016

Choose a reason for hiding this comment

epixa Jun 16, 2016

Choose a reason for hiding this comment

epixa commented Jun 16, 2016

jbudz commented Jun 16, 2016