Re-implement most of PR #7024 switch to Chrome browser #7442

LeeDr · 2016-06-13T21:05:20Z

This switches to use chrome for the integration tests, which has proven to give much better performance rendering Kibana.

It also turns on the new bail option available in version 3.1 of intern. This option will skip any test after a failed one.

Both of these changes are intended to improve performance of the integration tests since they are currently taking close to 15 minutes to run.

LeeDr · 2016-06-13T21:30:31Z

jenkins, test it

jbudz · 2016-06-13T21:38:23Z

@LeeDr this will need to change browserName in intern.js too

LeeDr · 2016-06-13T21:41:55Z

Thanks @jbudz ! Changed intern.js from firefox to chrome.

jbudz · 2016-06-14T13:00:09Z

jenkins, test it

jbudz · 2016-06-14T14:29:02Z

Looking good. Few comments:

Can we look into bumping intern to latest instead (3.2.3)?
Test failure on last run
So expectations are set properly, this doesn't seem to be running any faster on jenkins, we're still hovering around ~15 minutes
Are we bringing firefox back eventually? Thoughts on running tests on both browsers?

LeeDr · 2016-06-14T15:53:45Z

Bumped intern to latest (3.2.3)
Testing fix for failed test
Chrome tends to run faster than Firefox. Failures can slow it down a lot. I'm looking into some recently added tests that added 20 seconds test time.
Firefox testing just broke with the update to Firefox 47. It's possible to install Firefox 46 and turn off updates. But we'll need to switch to a new Marionette driver to support current Firefox versions. See Allow functional test automation on Firefox 47+ #7452

LeeDr · 2016-06-14T16:05:33Z

jenkins, test it

LeeDr · 2016-06-14T18:00:33Z

Locally, all tests are passing on Chrome in less than 8 minutes;

TOTAL: tested 1 platforms, 0/92 tests failed

real    7m37.892s

Still working on the failure issue.

LeeDr · 2016-06-15T19:25:56Z

build http://build-eu-00.elastic.co/job/kibana_core_pr/4181/ passed but I had an intermittent failure locally. Working on a fix.

"Additional stability improvements" commit 14b7d3a

build http://build-eu-00.elastic.co/job/kibana_core_pr/4190/ passed. Running again.

http://build-eu-00.elastic.co/job/kibana_core_pr/4195/console failed to collapse the time-picker after setting absolute time in _data_table visualize test. I added a getSpinnerDone between the clicking Go button and collapsing the time picker in headerPage.setAbsoluteRange(fromTime, toTime).

23:27:48.206: --Setting From Time : 2015-09-19 06:31:44.000
23:27:48.717: --Setting To Time : 2015-09-23 18:31:44.000
23:27:49.430: Taking screenshot "/home/jenkins/workspace/kibana_core_pr/test/screenshots/failure/failure_1466026069430_visualize app_visualize app.png"
SUITE ERROR
UnknownError: [POST http://localhost:4444/wd/hub/session/0e6cafb94b286a1dcd2c5f0b5a19e50d/element/0.6915926487210866-10/click] unknown error: Element is not clickable at point (1184, 422). Other element would receive the click: <div class="config-close remove">...</div>
...
  at Element.click  <node_modules/intern/node_modules/leadfoot/Element.js:163:15>
  at Command.<anonymous>  <node_modules/intern/node_modules/leadfoot/Command.js:680:19>
...
  at HeaderPage.collapseTimepicker  <test/support/pages/header_page.js:124:8>
  at Command.<anonymous>  <test/support/pages/header_page.js:116:21>
...
  at HeaderPage.setAbsoluteRange  <test/support/pages/header_page.js:115:8>
  at setAbsoluteRange  <test/functional/apps/visualize/_data_table.js:29:25>

Latest build failed http://build-eu-00.elastic.co/job/kibana_core_pr/4196/console

at DashboardPage.clickNewDashboard  <test/support/pages/dashboard_page.js:17:8>

So I added "getSpinnerDone at the end of loadSavedDashboard".

LeeDr · 2016-06-15T20:53:54Z

jenkins, test it

jbudz · 2016-06-16T20:12:16Z

test/support/pages/dashboard_page.js

@@ -75,6 +75,9 @@ export default (function () {
      .findByCssSelector('button.ng-scope[aria-label="Save Dashboard"]')
      .click()
      .then(function () {
+        return headerPage.getSpinnerDone();
+      })
+      .then(function () {
        return common.sleep(1000);


should these sleeps be added to all getSpinnerDone calls?

or I guess I'm asking, why there and not in other areas?

LeeDr · 2016-06-16T20:26:22Z

jenkins, test it

LeeDr · 2016-06-16T22:07:07Z

jenkins, test it

LeeDr · 2016-06-16T22:44:05Z

jenkins, test it

LeeDr · 2016-06-16T23:12:25Z

5 passes in a row!

LeeDr · 2016-06-16T23:15:14Z

jenkins, test it

LeeDr · 2016-06-17T13:20:21Z

jenkins, test it

LeeDr · 2016-06-17T13:29:25Z

jenkins, test it

LeeDr · 2016-06-17T13:43:40Z

Now 8 passes in a row!

jbudz · 2016-06-17T14:23:53Z

test/support/pages/header_page.js

-      .findByLinkText('Absolute').click();
+      .findByLinkText('Absolute').click()
+      .then(function () {
+        return self.getSpinnerDone();


this shouldn't be needed should it? clicking absolute shouldn't be triggering any requests

LeeDr · 2016-06-17T16:15:51Z

After the change to remove the 3 getSpinnerDone calls, the tests failed with the blank kibana screen. I don't think it's related.
Next commit was to CONTRIBUTING.md and the tests passed.
I'll trigger another run.

LeeDr · 2016-06-17T16:15:57Z

jenkins, test it

LeeDr · 2016-06-17T17:02:37Z

jenkins, test it

jbudz · 2016-06-17T19:57:13Z

LGTM

Re-implement most of PR elastic#7024 switch to Chrome browser Former-commit-id: e2ff6bb

`v91.3.1`⏩`v92.0.0-backport.0` --- ## [`v92.0.0-backport.0`](https://github.com/elastic/eui/releases/v92.0.0-backport.0) **This is a backport release only intended for use by Kibana.** **Bug fixes** - Fixed an `EuiTreeView` JSX Typescript error ([#7452](elastic/eui#7452)) - Fixed a color console warning being generated by disabled `EuiStep`s ([#7454](elastic/eui#7454)) ## [`v92.0.0`](https://github.com/elastic/eui/releases/v92.0.0) - Updated generic types of `EuiBasicTable`, `EuiInMemoryTable` and `EuiSearchBar.Query.execute` to add `extends object` constraint ([#7340](elastic/eui#7340)) - This change should have no impact on your applications since the updated types only affect properties that exclusively accept object values. - Added a new `EuiFlyoutResizable` component ([#7439](elastic/eui#7439)) - Updated `EuiTextArea` to accept `isClearable` and `icon` as props ([#7449](elastic/eui#7449)) **Bug fixes** - `EuiRange`/`EuiDualRange`'s track ticks & highlights now update their positions on resize ([#7442](elastic/eui#7442)) **Deprecations** - Updated `EuiFilterButton` to remove the second `.euiFilterButton__textShift` span wrapper. Target `.euiFilterButton__text` instead ([#7444](elastic/eui#7444)) **Breaking changes** - Removed deprecated `EuiNotificationEvent`. We recommend copying the component to your application if necessary ([#7434](elastic/eui#7434)) - Removed deprecated `EuiControlBar`. We recommend using `EuiBottomBar` instead ([#7435](elastic/eui#7435))

`v91.3.1`⏩`v92.0.0-backport.0` --- ## [`v92.0.0-backport.0`](https://github.com/elastic/eui/releases/v92.0.0-backport.0) **This is a backport release only intended for use by Kibana.** **Bug fixes** - Fixed an `EuiTreeView` JSX Typescript error ([elastic#7452](elastic/eui#7452)) - Fixed a color console warning being generated by disabled `EuiStep`s ([elastic#7454](elastic/eui#7454)) ## [`v92.0.0`](https://github.com/elastic/eui/releases/v92.0.0) - Updated generic types of `EuiBasicTable`, `EuiInMemoryTable` and `EuiSearchBar.Query.execute` to add `extends object` constraint ([elastic#7340](elastic/eui#7340)) - This change should have no impact on your applications since the updated types only affect properties that exclusively accept object values. - Added a new `EuiFlyoutResizable` component ([elastic#7439](elastic/eui#7439)) - Updated `EuiTextArea` to accept `isClearable` and `icon` as props ([elastic#7449](elastic/eui#7449)) **Bug fixes** - `EuiRange`/`EuiDualRange`'s track ticks & highlights now update their positions on resize ([elastic#7442](elastic/eui#7442)) **Deprecations** - Updated `EuiFilterButton` to remove the second `.euiFilterButton__textShift` span wrapper. Target `.euiFilterButton__text` instead ([elastic#7444](elastic/eui#7444)) **Breaking changes** - Removed deprecated `EuiNotificationEvent`. We recommend copying the component to your application if necessary ([elastic#7434](elastic/eui#7434)) - Removed deprecated `EuiControlBar`. We recommend using `EuiBottomBar` instead ([elastic#7435](elastic/eui#7435))

Re-implement most of PR elastic#7024 switch to Chrome browser

01255ee

Change browser from firefox to chrome. Add try in saveDashboard.

5d02617

LeeDr added review test labels Jun 13, 2016

LeeDr assigned jbudz Jun 13, 2016

This was referenced Jun 14, 2016

WIP Speed up integration tests and fail faster #7024

Closed

Replace most sleeps with waitForSpinnerDone #7450

Closed

Update intern version to 3.2.3, fix failing test

3e22acd

LeeDr mentioned this pull request Jun 14, 2016

Allow functional test automation on Firefox 47+ #7452

Closed

Testing a sleep between get and refresh

057ec2d

LeeDr added 5 commits June 15, 2016 11:19

getSpinnerDone in dashboard

d4914a3

Merge master

bfcb875

Merge branch 'master' into runTestsOnChrome

c650ab9

Remove auth from URL

8531d9b

Add a sleep back into saveDashboard

739b005

LeeDr removed the review label Jun 15, 2016

LeeDr unassigned jbudz Jun 15, 2016

Additional stability improvements

14b7d3a

LeeDr added 2 commits June 15, 2016 16:50

getSpinnerDone after setting absolute time range and clicking Go

e037140

getSpinnerDone at the end of loadSavedDashboard

475220a

jbudz reviewed Jun 16, 2016
View reviewed changes

remove some out of date comments

570f54c

jbudz reviewed Jun 17, 2016
View reviewed changes

LeeDr added 2 commits June 17, 2016 10:26

Remove a couple unneeded calls to getSpinnerDone

b7e1873

Update switch from Firefox to Chrome

5961982

LeeDr merged commit e2ff6bb into elastic:master Jun 17, 2016

LeeDr added the v5.0.0-alpha4 label Jun 17, 2016

jbudz mentioned this pull request Jun 20, 2016

Switch from Firefox to Chrome #7502

Merged

epixa added v5.0.0 and removed v5.0.0 labels Jun 28, 2016

airow pushed a commit to airow/kibana that referenced this pull request Feb 16, 2017

Merge pull request elastic#7442 from LeeDr/runTestsOnChrome

6c6c0b7

Re-implement most of PR elastic#7024 switch to Chrome browser Former-commit-id: e2ff6bb

LeeDr deleted the runTestsOnChrome branch May 23, 2017 13:57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Re-implement most of PR #7024 switch to Chrome browser #7442

Re-implement most of PR #7024 switch to Chrome browser #7442

LeeDr commented Jun 13, 2016

LeeDr commented Jun 13, 2016

jbudz commented Jun 13, 2016

LeeDr commented Jun 13, 2016

jbudz commented Jun 14, 2016

jbudz commented Jun 14, 2016

LeeDr commented Jun 14, 2016

LeeDr commented Jun 14, 2016

LeeDr commented Jun 14, 2016

LeeDr commented Jun 15, 2016 •

edited

Loading

LeeDr commented Jun 15, 2016

jbudz Jun 16, 2016 •

edited

Loading

LeeDr commented Jun 16, 2016

LeeDr commented Jun 16, 2016

LeeDr commented Jun 16, 2016

LeeDr commented Jun 16, 2016

LeeDr commented Jun 16, 2016

LeeDr commented Jun 17, 2016

LeeDr commented Jun 17, 2016

LeeDr commented Jun 17, 2016

jbudz Jun 17, 2016

LeeDr commented Jun 17, 2016

LeeDr commented Jun 17, 2016

LeeDr commented Jun 17, 2016

jbudz commented Jun 17, 2016

Re-implement most of PR #7024 switch to Chrome browser #7442

Re-implement most of PR #7024 switch to Chrome browser #7442

Conversation

LeeDr commented Jun 13, 2016

LeeDr commented Jun 13, 2016

jbudz commented Jun 13, 2016

LeeDr commented Jun 13, 2016

jbudz commented Jun 14, 2016

jbudz commented Jun 14, 2016

LeeDr commented Jun 14, 2016

LeeDr commented Jun 14, 2016

LeeDr commented Jun 14, 2016

LeeDr commented Jun 15, 2016 • edited Loading

LeeDr commented Jun 15, 2016

jbudz Jun 16, 2016 • edited Loading

Choose a reason for hiding this comment

LeeDr commented Jun 16, 2016

LeeDr commented Jun 16, 2016

LeeDr commented Jun 16, 2016

LeeDr commented Jun 16, 2016

LeeDr commented Jun 16, 2016

LeeDr commented Jun 17, 2016

LeeDr commented Jun 17, 2016

LeeDr commented Jun 17, 2016

jbudz Jun 17, 2016

Choose a reason for hiding this comment

LeeDr commented Jun 17, 2016

LeeDr commented Jun 17, 2016

LeeDr commented Jun 17, 2016

jbudz commented Jun 17, 2016

LeeDr commented Jun 15, 2016 •

edited

Loading

jbudz Jun 16, 2016 •

edited

Loading