Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solutions][Cases] Cases Redesign #73247

Merged
merged 43 commits into from
Sep 17, 2020
Merged

[Security Solutions][Cases] Cases Redesign #73247

merged 43 commits into from
Sep 17, 2020

Conversation

cnasikas
Copy link
Member

@cnasikas cnasikas commented Jul 27, 2020 •
edited
Loading

Summary

This PR redesign the case details page using the new EuiCommentList component and the new Markdown editor.

Screenshots

Markdown editor

Screenshot 2020-09-04 at 1 04 00 PM

Timeline editor

Screenshot 2020-09-16 at 12 39 51 PM

Timeline popup

Screenshot 2020-09-04 at 1 04 11 PM

Timeline preview

Screenshot 2020-09-04 at 1 04 39 PM

Syntax help

Screenshot 2020-09-16 at 12 44 03 PM

Edit actions

Screenshot 2020-09-04 at 1 06 47 PM

Tag actions

Screenshot 2020-09-04 at 1 05 45 PM

Case with actions

Screenshot 2020-09-04 at 1 06 41 PM

Comment with a timeline

Screenshot 2020-09-16 at 12 45 25 PM

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@cnasikas cnasikas changed the title [Security Solutions][] Fix key [Security Solutions][Cases][skip-ci] Cases Redesign Jul 27, 2020
@cnasikas cnasikas self-assigned this Jul 27, 2020
@cnasikas cnasikas added v7.10.0 v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:SIEM labels Jul 27, 2020
@cnasikas cnasikas changed the title [Security Solutions][Cases][skip-ci] Cases Redesign [Security Solutions][Cases] Cases Redesign Sep 7, 2020
@cnasikas cnasikas marked this pull request as ready for review September 7, 2020 13:07
@cnasikas cnasikas requested review from a team as code owners September 7, 2020 13:07
@elasticmachine
Copy link
Contributor

Pinging @elastic/siem (Team:SIEM)

@cnasikas cnasikas force-pushed the cases_redesign branch 2 times, most recently from d8a04d8 to 357b620 Compare September 14, 2020 07:41
XavierM
XavierM approved these changes Sep 16, 2020
View reviewed changes
Copy link
Contributor

@XavierM XavierM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job to bring us back with EUI!!! I really enjoyed reading the refactor around the EuiCommentList, it is perfect NOW!

yctercero
yctercero approved these changes Sep 16, 2020
View reviewed changes
Copy link
Contributor

@yctercero yctercero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - focused on just updating the detection's use of the new markdown component. It all worked really great, thank you so much for these updates!

@cnasikas
Copy link
Member Author

@elasticmachine merge upstream

@cnasikas
Copy link
Member Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

@kbn/optimizer bundle module count

id value diff baseline
securitySolution 2007 +9 1998

async chunks size

id value diff baseline
securitySolution 10.2MB +4.2KB 10.1MB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

stephmilovic
stephmilovic approved these changes Sep 17, 2020
View reviewed changes
Copy link
Contributor

@stephmilovic stephmilovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! This is awesome, thanks @cnasikas

@cnasikas cnasikas merged commit e616c15 into elastic:master Sep 17, 2020
@cnasikas cnasikas deleted the cases_redesign branch September 17, 2020 14:39
@cnasikas cnasikas mentioned this pull request Sep 17, 2020
Merged
cnasikas added a commit to cnasikas/kibana that referenced this pull request Sep 17, 2020
@cnasikas @XavierM
@yctercero @elasticmachine
[Security Solutions][Cases] Cases Redesign (elastic#73247)
631aaad 
Co-authored-by: Xavier Mouligneau <189600+XavierM@users.noreply.github.com>
Co-authored-by: Yara Tercero <yctercero@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
cnasikas added a commit that referenced this pull request Sep 17, 2020
@cnasikas @XavierM
@yctercero @elasticmachine
[7.x] [Security Solutions][Cases] Cases Redesign (#73247) (#77771)
b6be6e9 
Co-authored-by: Xavier Mouligneau <189600+XavierM@users.noreply.github.com>
Co-authored-by: Yara Tercero <yctercero@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
jloleysens added a commit to jloleysens/kibana that referenced this pull request Sep 18, 2020
@jloleysens
Merge branch 'master' of github.com:elastic/kibana into ingest-node/g…
6a85bac 
…rok/new-patterns-component-use-array

* 'master' of github.com:elastic/kibana: (140 commits)
  Add telemetry as an automatic privilege grant (elastic#77390)
  [Security Solutions][Cases] Cases Redesign (elastic#73247)
  Use Search API in TSVB (elastic#76274)
  [Mappings editor] Add support for constant_keyword field type (elastic#76564)
  [ML] Adds ML modules for Metrics UI Integration (elastic#76460)
  [Drilldowns] {{event.points}} in URL drilldown for VALUE_CLICK_TRIGGER (elastic#76771)
  Migrate status & stats APIs to KP + remove legacy status lib (elastic#76054)
  use App updater API instead of deprecated chrome.navLinks.update (elastic#77708)
  [CSM Dashboard] Remove points from line chart (elastic#77617)
  [APM] Trace timeline: Replace multi-fold function icons with new EuiIcon glyphs (elastic#77470)
  [Observability] Overview: Alerts section style improvements (elastic#77670)
  Bump the Node.js version used by Docker in CI (elastic#77714)
  Upgrade all minimist (sub)dependencies to version ^1.2.5 (elastic#60284)
  Remove unneeded forced package resolutions (elastic#77467)
  [ML] Add metrics app to check made for internal custom URLs (elastic#77627)
  Functional tests - add supertest for test_user (elastic#77584)
  [ML] Adding option to create AD jobs without starting the datafeed (elastic#77484)
  Bump node-fetch to 2.6.1 (elastic#77445)
  Bump sharkdown from v0.1.0 to v0.1.1 (elastic#77607)
  [APM]fixing y axis on transaction error rate to 100% (elastic#77609)
  ...

# Conflicts:
#	x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/manage_processor_form.container.tsx
#	x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/manage_processor_form.tsx
#	x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/processor_form/field_components/drag_and_drop_text_list.scss
#	x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/processor_form/field_components/drag_and_drop_text_list.tsx
#	x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/processor_form/field_components/text_editor.scss
#	x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/processor_form/processors/grok.test.tsx
@cnasikas cnasikas mentioned this pull request Sep 30, 2020
Closed
@cnasikas cnasikas mentioned this pull request Oct 13, 2020
Merged
5 tasks
@cnasikas cnasikas mentioned this pull request Nov 26, 2020
Closed
@MindyRS MindyRS added the Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. label Sep 23, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XavierM XavierM XavierM approved these changes

@stephmilovic stephmilovic stephmilovic approved these changes

@yctercero yctercero yctercero approved these changes

@patrykkopycinski patrykkopycinski Awaiting requested review from patrykkopycinski

@marrasherrier marrasherrier Awaiting requested review from marrasherrier

Assignees

@cnasikas cnasikas

Labels
release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:SIEM v7.10.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@cnasikas @elasticmachine @stephmilovic @kibanamachine @XavierM @yctercero @MindyRS