Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translation Enablement - Phase 1A #7247

Closed
wants to merge 5 commits into from
Closed

Translation Enablement - Phase 1A #7247

wants to merge 5 commits into from

Commits on May 20, 2016

  1. Translation Enablement - Phase 1A 

    * documented in TRANSLATION.md
* using angular-translate
* English strings in src/plugins/kibana/public/settings/sections/indices/i18n/en.json

Fixes: elastic#7255

Author: Scott Russell <scott_russell@us.ibm.com>
Author: Martin Hickey <martin.hickey@ie.ibm.com>
Author: Steven R. Loomis <srloomis@us.ibm.com>
    @srl295
    scott russell authored and srl295 committed May 20, 2016
    Configuration menu
    Copy the full SHA
    e5378a5 View commit details
    Browse the repository at this point in the history

  2. [test] call $timeout.flush() before debounce tests 

    * Otherwise, the '$http GET' to fetch translation resources
shows up as a deferred task here.

* May have fixed elastic#5446
    @srl295
    srl295 committed May 20, 2016
    Configuration menu
    Copy the full SHA
    5d9959c View commit details
    Browse the repository at this point in the history

Commits on Jun 1, 2016

  1. docs - TRANSLATION.md as per review comments 

    - mention 'fork' rather than 'check out'
- remove TODOs
    @srl295
    srl295 committed Jun 1, 2016
    Configuration menu
    Copy the full SHA
    e63fda3 View commit details
    Browse the repository at this point in the history

  2. Add testing for Kibana globalization 

    Testing covers:
  - Missing locale translation files in a localization directory
  - Missing translation identifiers in locale translation files
  - Missing translations in a locale translation file
The tests assume the english locale (en) in a localization directory is the
reference file for checking.
    @hickeyma
    hickeyma committed Jun 1, 2016
    Configuration menu
    Copy the full SHA
    99dea63 View commit details
    Browse the repository at this point in the history

Commits on Jun 2, 2016

  1. Update kibana globaliation unit tests to test translation identifiers… 

    … are used

Check the translation identifiers in locale file against code files for
that localization directory to check for stray or stale identifiers.
    @hickeyma
    hickeyma committed Jun 2, 2016
    Configuration menu
    Copy the full SHA
    f13e944 View commit details
    Browse the repository at this point in the history