Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Register navLink actions for declared applications #72109

Merged
merged 1 commit into from
Jul 17, 2020
Merged

Register navLink actions for declared applications #72109

merged 1 commit into from
Jul 17, 2020

Conversation

legrego
Copy link
Member

@legrego legrego commented Jul 16, 2020 •
edited
Loading

This is a followup to #71106.

Since migrating to the KP, we need to treat apps declared by each Feature as a possible navLinkId. #71106 handles this for most cases, but we (I) forgot to adjust the privilege actions to account for this.

This PR will generate a navLinkId action for each declared app in addition to the existing navLinkId declared on the feature.

Resolves #71186

@legrego legrego changed the title Fegister navLink actions for declared applications Register navLink actions for declared applications Jul 16, 2020
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@legrego legrego added Feature:Security/Feature Controls Platform Security - Spaces & Role Mgmt feature controls release_note:skip Skip the PR/issue when compiling release notes Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! v7.10.0 v7.9.0 v8.0.0 labels Jul 16, 2020
@legrego legrego marked this pull request as ready for review July 16, 2020 18:56
@legrego legrego requested a review from a team as a code owner July 16, 2020 18:56
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-security (Team:Security)

@legrego legrego requested a review from azasypkin July 16, 2020 21:40
azasypkin
azasypkin approved these changes Jul 17, 2020
View reviewed changes
Copy link
Member

@azasypkin azasypkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested locally and it seems to work as expected, thanks!

@legrego legrego merged commit 99e14aa into elastic:master Jul 17, 2020
@legrego legrego deleted the fc/navlink-apps-fix branch July 17, 2020 09:38
This was referenced Jul 17, 2020
Merged
Merged
legrego added a commit to legrego/kibana that referenced this pull request Jul 17, 2020
@legrego
Register navLink actions for declared applications (elastic#72109)
6e925bb
legrego added a commit to legrego/kibana that referenced this pull request Jul 17, 2020
@legrego
Register navLink actions for declared applications (elastic#72109)
76c8673
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jul 17, 2020
@gmmorris
Merge branch 'master' into task-manager/batch-update-delete
edb3f1e 
* master: (214 commits)
  replacing hard coded links for ela.st (elastic#72240)
  skip flaky suite (elastic#60865)
  chore(NA): teardown dynamic dll plugin (elastic#72096)
  Register navLink actions for declared applications (elastic#72109)
  Fix value for process.hash.sha256 draggable (elastic#72142)
  Call setupIngest before fleet_install tests (elastic#72214)
  [Security Solution][Detections] Better toast errors (elastic#72205)
  skip flaky suite (elastic#64696)
  [Security Solution][Detections] Disable exceptions for Threshold and ML rules (elastic#72137)
  [Security Solution][Detections,Lists] Miscellaneous post-FF fixes (elastic#71990)
  [baseline/capture] use high-memory nodes with ramDisks (elastic#71894)
  skip flaky suite (elastic#77207)
  [Maps] Fix issue preventing TMS from rendering correctly (elastic#71946)
  using test_user with minimum privs (elastic#71988)
  Fixed Webhook connector doesn't retain added HTTP header settings (elastic#71924)
  [Ingest Manager] Do not show enrolling and unenrolling agents as online in agent counters (elastic#71921)
  [Maps] fix 'New Map' from getting added to recently accessed (elastic#72125)
  [Visualizations] Pass 'aggs' parameter to custom request handlers (elastic#71423)
  [Monitoring] Out of the box alert tweaks (elastic#71942)
  [ML] Fix datafeed start time is incorrect when the job has trailing empty buckets (elastic#71976)
  ...
legrego added a commit that referenced this pull request Jul 17, 2020
@legrego
Register navLink actions for declared applications (#72109) (#72246)
a8477b0
legrego added a commit that referenced this pull request Jul 17, 2020
@legrego
[7.9] Register navLink actions for declared applications (#72109) (#7…
2d4042c 
…2247)
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jul 17, 2020
@gmmorris
Merge branch 'master' into alerting/consumer-based-rbac
cbee849 
* master: (55 commits)
  updates 'External alerts' tab text (elastic#72237)
  [Security Solution][Case] Fix connector's dropdown with conflicting requests (elastic#72037)
  replacing hard coded links for ela.st (elastic#72240)
  skip flaky suite (elastic#60865)
  chore(NA): teardown dynamic dll plugin (elastic#72096)
  Register navLink actions for declared applications (elastic#72109)
  Fix value for process.hash.sha256 draggable (elastic#72142)
  Call setupIngest before fleet_install tests (elastic#72214)
  [Security Solution][Detections] Better toast errors (elastic#72205)
  skip flaky suite (elastic#64696)
  [Security Solution][Detections] Disable exceptions for Threshold and ML rules (elastic#72137)
  [Security Solution][Detections,Lists] Miscellaneous post-FF fixes (elastic#71990)
  [baseline/capture] use high-memory nodes with ramDisks (elastic#71894)
  skip flaky suite (elastic#77207)
  [Maps] Fix issue preventing TMS from rendering correctly (elastic#71946)
  using test_user with minimum privs (elastic#71988)
  Fixed Webhook connector doesn't retain added HTTP header settings (elastic#71924)
  [Ingest Manager] Do not show enrolling and unenrolling agents as online in agent counters (elastic#71921)
  [Maps] fix 'New Map' from getting added to recently accessed (elastic#72125)
  [Visualizations] Pass 'aggs' parameter to custom request handlers (elastic#71423)
  ...
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jul 17, 2020
@gmmorris
Merge branch 'alerting/consumer-based-rbac' into alerting/management-…
fead80a 
…feature-privileges

* alerting/consumer-based-rbac: (56 commits)
  take into account which features available in the active space
  updates 'External alerts' tab text (elastic#72237)
  [Security Solution][Case] Fix connector's dropdown with conflicting requests (elastic#72037)
  replacing hard coded links for ela.st (elastic#72240)
  skip flaky suite (elastic#60865)
  chore(NA): teardown dynamic dll plugin (elastic#72096)
  Register navLink actions for declared applications (elastic#72109)
  Fix value for process.hash.sha256 draggable (elastic#72142)
  Call setupIngest before fleet_install tests (elastic#72214)
  [Security Solution][Detections] Better toast errors (elastic#72205)
  skip flaky suite (elastic#64696)
  [Security Solution][Detections] Disable exceptions for Threshold and ML rules (elastic#72137)
  [Security Solution][Detections,Lists] Miscellaneous post-FF fixes (elastic#71990)
  [baseline/capture] use high-memory nodes with ramDisks (elastic#71894)
  skip flaky suite (elastic#77207)
  [Maps] Fix issue preventing TMS from rendering correctly (elastic#71946)
  using test_user with minimum privs (elastic#71988)
  Fixed Webhook connector doesn't retain added HTTP header settings (elastic#71924)
  [Ingest Manager] Do not show enrolling and unenrolling agents as online in agent counters (elastic#71921)
  [Maps] fix 'New Map' from getting added to recently accessed (elastic#72125)
  ...
chrisronline pushed a commit to chrisronline/kibana that referenced this pull request Jul 17, 2020
@legrego @chrisronline
Register navLink actions for declared applications (elastic#72109)
0efd8f6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azasypkin azasypkin azasypkin approved these changes

Assignees
No one assigned
Labels
Feature:Security/Feature Controls Platform Security - Spaces & Role Mgmt feature controls release_note:skip Skip the PR/issue when compiling release notes Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! v7.9.0 v7.10.0 v8.0.0
Projects
None yet
Milestone
No milestone
4 participants
@legrego @kibanamachine @elasticmachine @azasypkin