Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Discover URL generator #67937

Merged
merged 21 commits into from
Jun 5, 2020
Merged

Discover URL generator #67937

merged 21 commits into from
Jun 5, 2020

Conversation

streamich
Copy link
Contributor

@streamich streamich commented Jun 2, 2020 •
edited
Loading

Summary

Adds URL generator for Discover app. This is needed for #62652 and #60227

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@streamich streamich marked this pull request as ready for review June 2, 2020 13:00
@streamich streamich requested a review from a team June 2, 2020 13:00
@streamich streamich requested a review from a team as a code owner June 2, 2020 13:00
@streamich streamich added Feature:Discover Discover Application release_note:skip Skip the PR/issue when compiling release notes review Team:AppArch Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.9.0 labels Jun 2, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@streamich streamich requested a review from kertal June 2, 2020 17:02
Dosant
Dosant approved these changes Jun 3, 2020
View reviewed changes
Copy link
Contributor

@Dosant Dosant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, but didn't test. (no way to test from UI)

Does it make sense to use it in our current example drilldown to discover? Then we could actually click this through UI.

@streamich streamich changed the title Discover url generator Discover URL generator Jun 3, 2020
@streamich streamich requested a review from kertal June 4, 2020 11:14
kertal
kertal approved these changes Jun 4, 2020
View reviewed changes
Copy link
Member

@kertal kertal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, tested the example in Chrome 83, MacOs 10.14.6, could add a discover drilldown in the example, link is added, drilldown available, link works 👍

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@streamich streamich merged commit 7ea8ef1 into elastic:master Jun 5, 2020
@streamich streamich mentioned this pull request Jun 5, 2020
Merged
streamich added a commit that referenced this pull request Jun 5, 2020
@streamich
Discover URL generator (#67937) (#68370)
5f6290c 
* feat: 🎸 stub discover_enhanced plugin

* feat: 🎸 add Discover URL generator

* chore: 🤖 remove x-pack plugin

* fix: 🐛 fix types in URL generator

* test: 💍 setup test file for Discover URL generator

* feat: 🎸 expose Discover URL generator in start life-cycle

* feat: 🎸 add ability to specify saved search ID in URL generator

* docs: ✏️ add JSDoc for Discover URL generator

* fix: 🐛 set correctly global filters in Discover URL generator

* docs: ✏️ remove wrong comment in JsDoc

* style: 💄 format single arg arrow function with parens

* chore: 🤖 disable toggles in Dicover sample drilldown

* feat: 🎸 use Discover URL generator in example plugin

* test: 💍 add urlGenerator mock

* test: 💍 add .registerUrlGenerator() test mock

* test: 💍 correct Karma mock for "share" plugin URL generator
# Conflicts:
#	x-pack/examples/ui_actions_enhanced_examples/kibana.json
#	x-pack/examples/ui_actions_enhanced_examples/public/plugin.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kertal kertal kertal approved these changes

@Dosant Dosant Dosant approved these changes

Assignees
No one assigned
Labels
Feature:Discover Discover Application release_note:skip Skip the PR/issue when compiling release notes review Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.9.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@streamich @elasticmachine @kibanamachine @kertal @Dosant