Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.7] [SIEM] [Maps] Fixes Network Map empty tooltip (#66828) #66955

Merged
merged 1 commit into from
May 19, 2020

Commits on May 19, 2020

  1. [SIEM] [Maps] Fixes Network Map empty tooltip (elastic#66828)

    ## Summary
    
    Resolves elastic#63474, and expands `ITooltipProperty`'s `rawValue` type to include `string[]` as mentioned [here](elastic#61264 (comment)).
    
    ![image](https://user-images.githubusercontent.com/2946766/82100568-2c0e1480-96c7-11ea-958e-5b1c6b6a3db9.png)
    
    ### Checklist
    
    Delete any items that are not applicable to this PR.
    
    - [X] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios
    
    # Conflicts:
    #	x-pack/plugins/maps/public/classes/fields/es_agg_field.ts
    #	x-pack/plugins/maps/public/classes/fields/es_doc_field.ts
    #	x-pack/plugins/maps/public/classes/fields/field.ts
    #	x-pack/plugins/maps/public/classes/tooltips/es_tooltip_property.ts
    #	x-pack/plugins/maps/public/classes/tooltips/join_tooltip_property.ts
    #	x-pack/plugins/maps/public/classes/tooltips/tooltip_property.ts
    #	x-pack/plugins/maps/public/index.ts
    #	x-pack/plugins/siem/public/network/components/embeddables/map_tool_tip/line_tool_tip_content.tsx
    #	x-pack/plugins/siem/public/network/components/embeddables/map_tool_tip/map_tool_tip.tsx
    #	x-pack/plugins/siem/public/network/components/embeddables/map_tool_tip/point_tool_tip_content.test.tsx
    #	x-pack/plugins/siem/public/network/components/embeddables/map_tool_tip/point_tool_tip_content.tsx
    #	x-pack/plugins/siem/public/network/components/embeddables/types.ts
    spong committed May 19, 2020
    Configuration menu
    Copy the full SHA
    68b8baa View commit details
    Browse the repository at this point in the history