Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove FIXME and links to issues #64833

Merged
merged 1 commit into from
Apr 30, 2020
Merged

Remove FIXME and links to issues #64833

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion x-pack/plugins/endpoint/public/applications/endpoint/store/hosts/middleware.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,6 @@ export const hostMiddlewareFactory: ImmutableMiddlewareFactory<HostState> = core
type: 'serverReturnedHostDetails',
payload: response,
});
// FIXME: once we have the API implementation in place, we should call it parallel with the above api call and then dispatch this with the results of the second call
dispatch({
type: 'serverReturnedHostPolicyResponse',
payload: {
Expand Down
2 changes: 0 additions & 2 deletions x-pack/plugins/endpoint/server/routes/alerts/list/lib/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,8 +60,6 @@ export const getRequestData = async (
reqData.fromIndex = reqData.pageIndex * reqData.pageSize;
}

// See: https://github.com/elastic/elasticsearch-js/issues/662
// and https://github.com/elastic/endpoint-app-team/issues/221
if (
reqData.searchBefore !== undefined &&
reqData.searchBefore[0] === '' &&
Expand Down
1 change: 0 additions & 1 deletion x-pack/plugins/endpoint/server/routes/metadata/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,6 @@ async function enrichHostMetadata(
try {
/**
* Get agent status by elastic agent id if available or use the host id.
* https://github.com/elastic/endpoint-app-team/issues/354
*/

if (!elasticAgentId) {
Expand Down