[PoC] persisted state service #63451
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/kibana-app-arch (Team:AppArch) |
7 tasks
lukeelmers
reviewed
Apr 14, 2020
There was a problem hiding this comment.
Pushed some updates to clean up the typings & remove casting, and I think everything works now. From another plugin, if you do this:
async start(core, { share }) {
const visDef = await share.persistableState.get('visualizations');
}...then you should get the correct type on visDef, with autocomplete working.
I also added mocks for the share plugin since there was a TS compilation failure on the vis mocks.
TS won't pass just yet though; there are a few failures related to vis tests that are using extractReferences, but AFAIK nothing related to the new service.
src/plugins/share/public/persistable_state/persistable_state_service.ts
Outdated
Show resolved
Hide resolved
Comment on lines
79
to
81
| // TODO: should be PersistableState<SerializableState> | ||
| [key: string]: PersistableState<unknown>; | ||
| } |
There was a problem hiding this comment.
Same comment on SerializableState -- this should replace unknown once VisSavedObject is updated or changed to a different interface.
Comment on lines
22
to
26
| type State = string | number | boolean | null | undefined | SerializableState; | ||
|
|
||
| interface SerializableState { | ||
| [key: string]: State | State[]; | ||
| } |
There was a problem hiding this comment.
This is more or less ripped off from core's SavedObjectAttributes, just with a different name to prevent confusion.
💔 Build Failed
Failed CI Steps
Test FailuresKibana Pipeline / kibana-oss-agent / Accessibility Tests.test/accessibility/apps/discover·ts.Discover "before all" hook for "main view"Standard OutStack TraceKibana Pipeline / kibana-oss-agent / Chrome UI Functional Tests.test/functional/apps/console/_console·ts.console app console app "before all" hook for "should show the default request"Standard OutStack TraceKibana Pipeline / kibana-oss-agent / Chrome UI Functional Tests.test/functional/apps/console/_console·ts.console app console app "before all" hook for "should show the default request"Standard OutStack Traceand 25 more failures, only showing the first 3. History
To update your PR or re-run it, just comment with: |
ppisljar
added
v7.8.0
v8.0.0
release_note:skip
ppisljar
force-pushed
the
stateMigration
branch
from
f5d88da
to
c96387f
Compare
|
This seems like a new feature or enhancement so it shouldn't go in v7.8.1 patch release. I removed that label. You probably want to add v7.9.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
continuing on #63085
Checklist
Delete any items that are not applicable to this PR.
For maintainers