[SIEM] Update Timeline to use the latest euiFlyoutBody style #59524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[A recent update to EUI](elastic/eui#2837) requires an update to Timeline to restore its original padding, per the before / after screenshots below: ### Before The previous code, which was using the `euiFlyoutBody__overflow` style, has extra padding (before this PR):  ### After Chrome `80.0.3987.132` The new code in this PR uses `euiFlyoutBody__overflowContent`, which restores the Timeline's original padding:   ### After Firefox `73.0.1`  ### After Safari `13.0.5` 
andrew-goldstein
added
Team:SIEM
v8.0.0
release_note:skip
|
Pinging @elastic/siem (Team:SIEM) |
patrykkopycinski
approved these changes
Mar 6, 2020
💚 Build SucceededTo update your PR or re-run it, just comment with: |
andrew-goldstein
added a commit
that referenced
this pull request
Mar 6, 2020
…#59561) ## [SIEM] Update Timeline to use the latest euiFlyoutBody style [A recent update to EUI](elastic/eui#2837) requires an update to Timeline to restore its original padding, per the before / after screenshots below: ### Before The previous code, which was using the `euiFlyoutBody__overflow` style, has extra padding (before this PR):  ### After Chrome `80.0.3987.132` The new code in this PR uses `euiFlyoutBody__overflowContent`, which restores the Timeline's original padding:   ### After Firefox `73.0.1`  ### After Safari `13.0.5` 
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Mar 9, 2020
* master: (154 commits) Add an optional authentication mode for HTTP resources (elastic#58589) Implement embeddable drilldown menu options (elastic#59232) [Alerting] "Create alert" graph visualization design improvements (elastic#59399) Alerting update route throttle property is missing (elastic#59580) [SIEM] Adds 'Load prebuilt rules' Cypress test (elastic#59529) Show error if field is not found during filter rendering (elastic#59298) Navigate back to discover app during test, because the saved search from the preceding test has major performance problems when used with this test (elastic#59571) Check for alert dialog when doing a force logout (elastic#59329) ensure fs deletes are not cwd dependent (elastic#59570) Empty message for APM service map (elastic#59518) [Drilldowns] <ActionWizard/> Component (elastic#59032) [Reporting] Improve the page exit error messages (elastic#59351) Ensure logged out starting state for tests that need it (elastic#59322) Hide input value from kbn-config-schema error messages (elastic#58843) [ML] Transforms: Migrate client plugin to NP. (elastic#59443) [ML] Disable failing functional tests [SIEM] Update Timeline to use the latest euiFlyoutBody style (elastic#59524) Temporarily remove the project mappings for PR labels (elastic#59493) [Alerting] replace index threshold graph usage of watcher APIs with new API (elastic#59385) [ML] Show view series link in anomalies table for machine_learning_user role (elastic#59549) ...
jkelastic
pushed a commit
to jkelastic/kibana
that referenced
this pull request
Mar 12, 2020
…#59524) ## [SIEM] Update Timeline to use the latest euiFlyoutBody style [A recent update to EUI](elastic/eui#2837) requires an update to Timeline to restore its original padding, per the before / after screenshots below: ### Before The previous code, which was using the `euiFlyoutBody__overflow` style, has extra padding (before this PR):  ### After Chrome `80.0.3987.132` The new code in this PR uses `euiFlyoutBody__overflowContent`, which restores the Timeline's original padding:   ### After Firefox `73.0.1`  ### After Safari `13.0.5` 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[SIEM] Update Timeline to use the latest euiFlyoutBody style
A recent update to EUI requires an update to Timeline to restore its original padding, per the before / after screenshots below:
Before
The previous code, which was using the
euiFlyoutBody__overflowstyle, has extra padding (before this PR):After Chrome
80.0.3987.132The new code in this PR uses
euiFlyoutBody__overflowContent, which restores the Timeline's original padding:After Firefox
73.0.1After Safari
13.0.5