Map date histogram values from 4.0 format to 4.1 format #4150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| deserialize: function (state, agg) { | ||
| var interval = _.find(intervalOptions, {val: state}); | ||
| return interval || _.find(intervalOptions, function (option) { | ||
| // For upgrading from 4.0.x to 4.1.x - intervals are now stored as 'y' instead of 'year', |
There was a problem hiding this comment.
Can you scoot this left two-spaces?
There was a problem hiding this comment.
Whoops. Stupid IntelliJ.
| @@ -71,8 +72,16 @@ define(function (require) { | |||
| { | |||
| name: 'interval', | |||
| type: 'optioned', | |||
| deserialize: function (state, agg) { | |||
There was a problem hiding this comment.
agg isn't being used, it can be removed
|
This has a side effect of defaulting back to |
|
🈺 ship it ™️ 🈚 |
w33ble
added a commit
that referenced
this pull request
Jun 9, 2015
Map date histogram values from 4.0 format to 4.1 format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The format in which date histogram intervals are saved was changed in #3237. This caused issues with upgrading from 4.0 to 4.1, as the intervals would be lost and it would automatically revert to
auto.This PR maps old values to the new values by comparing if the two are equal according to
moment.duration:This works for all previous options:
second,minute,hour,day,week,month,year.However, when a user goes to save a visualization, it will overwrite it with the new format (
s,m,h,d,w,M,y).Closes #4149.