bower & livereload #334
Closed
bower & livereload #334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
= relative urls changed relative urls to absolute urls = leaflet leaflet dont include their build in dist. that's why I used node_modules I had to change L.Icon.Default.imagePath because it was pointing to leaflet.label plugin = leftovers jquery vector map dont provide a build so it's still an unmanged dependecy bootstrap dark & light: custom css for kibana ?
|
I'm afraid I don't see the benefit to bower here. It forms a barrier to installation by creating an unnecessary dependency on nodejs. While this might have some small benefit to developers, it would annoy many users |
|
I totally agree with you. I will create a dist grunt task, every release this task will be run and package dependencies minified pushed into the repo |
== dist folder when developing dist folder contain source artifact when kibana is ready for a release the dist grunt task can be run to copy minified artifact in the dist folder if present. this way, we dont have to change the url/src inside of html and javascript files. One could have use grunt-usemin, but grunt-usemin would not parse javascript files thus, labjs could not point to the right artifact. It look like they use requirejs and have a way to set this up.... == bootstrap bootstrap/dark.css and bootstrap/light.css files are copied to bower_component to be generated. the output goes to dist since it's a product of the bootstrap artifact with bootstrap/dark the input text was gray on gray, so I added type=text in bootswatch to override that with white on gray. (arround line 423) == relative url switched some relative url to absolute url (load_big, js/*) == remove sample nodejs server connect is suitable for this
was not rendeing pie
|
@rashidkpc can you approve/disaprove this pull request so I can rebase it ? Thanks |
|
I'm going to close this, go ahead and rebase and I'll review it. |
spalger
pushed a commit
that referenced
this pull request
Oct 6, 2014
spalger
pushed a commit
to spalger/kibana
that referenced
this pull request
Mar 3, 2016
harper-carroll
pushed a commit
to harper-carroll/kibana
that referenced
this pull request
Jul 11, 2016
Add encrypt message
w33ble
pushed a commit
to w33ble/kibana
that referenced
this pull request
Sep 13, 2018
* Changed dev dependency package.json. Used link to eslint-config-kibana instead of version number for @elastic/eslint-config-kibana * Added eslint-plugin-no-unsanitized
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.