[Maps] do not show "terms join" UI for ES geo grid source #30309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nreese
added
v7.0.0
[Deprecated-Use Team:Presentation]Team:Geo
|
Pinging @elastic/kibana-gis |
thomasneirynck
approved these changes
Feb 6, 2019
💔 Build Failed |
💔 Build Failed |
|
jenkins, test this |
💚 Build Succeeded |
nreese
added a commit
to nreese/kibana
that referenced
this pull request
Feb 7, 2019
nreese
added a commit
to nreese/kibana
that referenced
this pull request
Feb 7, 2019
This was referenced Feb 7, 2019
nreese
added a commit
that referenced
this pull request
Feb 7, 2019
nreese
added a commit
that referenced
this pull request
Feb 7, 2019
nreese
added
the
release_note:skip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Joins used to only be allowed for vector layers that where not filtered by bounds. This was in the process of being changed but #29204 accidentally slipped in a change to make all vector layers allow joins.
This PR cleans up the code accidentally checked in by #29204 and ensures that layers with es_geo_grid source do not support joins but all other layers with vector sources do.